third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp - Issue 2526343003: Introduce new security restrictions in FetchEvent.respondWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

Issue 2526343003: Introduce new security restrictions in FetchEvent.respondWith(). (Closed)

Patch Set: incorporated falken's comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.h ('k') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h » ('j') | third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

index b0ade794d0796ee4f748d083735e13c61ea506f6..2fcc3e04c3aa8b7357eca90facfef93793090ef2 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp

@@ -15,13 +15,14 @@ ForeignFetchRespondWithObserver* ForeignFetchRespondWithObserver::create(

int eventID,

const KURL& requestURL,

WebURLRequest::FetchRequestMode requestMode,

+ WebURLRequest::FetchRedirectMode redirectMode,

WebURLRequest::FrameType frameType,

WebURLRequest::RequestContext requestContext,

PassRefPtr<SecurityOrigin> requestOrigin,

WaitUntilObserver* observer) {

return new ForeignFetchRespondWithObserver(

- context, eventID, requestURL, requestMode, frameType, requestContext,

- std::move(requestOrigin), observer);

+ context, eventID, requestURL, requestMode, redirectMode, frameType,

+ requestContext, std::move(requestOrigin), observer);

}

void ForeignFetchRespondWithObserver::responseWasFulfilled(

@@ -95,6 +96,7 @@ ForeignFetchRespondWithObserver::ForeignFetchRespondWithObserver(

int eventID,

const KURL& requestURL,

WebURLRequest::FetchRequestMode requestMode,

+ WebURLRequest::FetchRedirectMode redirectMode,

WebURLRequest::FrameType frameType,

WebURLRequest::RequestContext requestContext,

PassRefPtr<SecurityOrigin> requestOrigin,

@@ -103,6 +105,7 @@ ForeignFetchRespondWithObserver::ForeignFetchRespondWithObserver(

eventID,

requestURL,

requestMode,

+ redirectMode,

frameType,

requestContext,

observer),