Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 252633007: Have field ordering for method parameters and response starts at 0. (Closed)

Created:
6 years, 8 months ago by qsr
Modified:
6 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Have field ordering for method parameters and response starts at 0. With the current implementation, the field ordering start with 1, while it must starts with 0 for structs. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/pack.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
qsr
6 years, 8 months ago (2014-04-25 13:53:23 UTC) #1
DaveMoore
lgtm
6 years, 8 months ago (2014-04-25 17:23:48 UTC) #2
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-28 07:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/252633007/1
6 years, 7 months ago (2014-04-28 07:52:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 08:51:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 08:51:29 UTC) #6
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-28 08:52:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/252633007/1
6 years, 7 months ago (2014-04-28 08:53:02 UTC) #8
qsr
The CQ bit was unchecked by qsr@chromium.org
6 years, 7 months ago (2014-04-28 13:35:29 UTC) #9
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-28 13:35:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/252633007/1
6 years, 7 months ago (2014-04-28 13:36:00 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:39:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
6 years, 7 months ago (2014-04-28 16:39:17 UTC) #13
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-04-29 07:38:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/252633007/1
6 years, 7 months ago (2014-04-29 07:41:06 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:46:56 UTC) #16
Message was sent while issue was closed.
Change committed as 266774

Powered by Google App Engine
This is Rietveld 408576698