mojo/public/tools/bindings/pylib/mojom/generate/pack.py - Issue 252633007: Have field ordering for method parameters and response starts at 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

Issue 252633007: Have field ordering for method parameters and response starts at 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

index 52caa0f94536973aa3fc7d8cce20c324de91f995..019fe48286edbae8090d97ae13da9fe43437f679 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

@@ -81,7 +81,7 @@ class PackedStruct(object):

# Start by sorting by ordinal.

src_fields = []

- ordinal = 1

+ ordinal = 0

for field in struct.fields:

if field.ordinal is not None:

ordinal = field.ordinal

« no previous file with comments | « no previous file | no next file » | no next file with comments »