Source/wtf/HashTraits.h - Issue 252633005: Enable WTF::HashSet<OwnPtr<> >

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/HashTraits.h

Issue 252633005: Enable WTF::HashSet<OwnPtr<> > (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed implicit conversion in PtrHash<RefPtr>::equal() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/HashTraits.h

diff --git a/Source/wtf/HashTraits.h b/Source/wtf/HashTraits.h

index fdf03db06934f77a42f57d1de4787f7c968ace22..eba0bd69d6ecba8b9e39d8a65269c2fc68284118 100644

--- a/Source/wtf/HashTraits.h

+++ b/Source/wtf/HashTraits.h

@@ -144,6 +144,11 @@ namespace WTF {

static EmptyValueType emptyValue() { return nullptr; }

+ static const bool hasIsEmptyValueFunction = true;

+ static bool isEmptyValue(const OwnPtr& value) { return !value; }

+ typedef typename OwnPtr::PtrType PeekInType;

typedef PassOwnPtr PassInType;

static void store(PassOwnPtr value, OwnPtr& storage) { storage = value; }