Source/wtf/HashTable.h - Issue 252633005: Enable WTF::HashSet<OwnPtr<> >

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/HashTable.h

Issue 252633005: Enable WTF::HashSet<OwnPtr<> > (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed implicit conversion in PtrHash<RefPtr>::equal() Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/HashTable.h

diff --git a/Source/wtf/HashTable.h b/Source/wtf/HashTable.h

index 41d4397597855cea4132638ff52c38d7e4665aea..8e6d120577d30dd80a8e94028874b6dd94e771dd 100644

--- a/Source/wtf/HashTable.h

+++ b/Source/wtf/HashTable.h

@@ -299,7 +299,7 @@ namespace WTF {

typedef Value ValueType;

typedef Extractor ExtractorType;

typedef KeyTraits KeyTraitsType;

- typedef typename Traits::PeekInType ValuePeekInType;

+ typedef typename Traits::PassInType ValuePassInType;

typedef IdentityHashTranslator<HashFunctions> IdentityTranslatorType;

typedef HashTableAddResult<HashTable, ValueType> AddResult;

@@ -374,7 +374,7 @@ namespace WTF {

unsigned capacity() const { return m_tableSize; }

bool isEmpty() const { return !m_keyCount; }

- AddResult add(ValuePeekInType value)

+ AddResult add(ValuePassInType value)

{

return add<IdentityTranslatorType>(Extractor::extract(value), value);

}