Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 2526293002: [wrapper-tracing] Untangle non-trivial mixin ctors (Closed)
Patch Set: s/new BodyStreamBuffer/BodyStreamBuffer::create/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Response.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Response.cpp b/third_party/WebKit/Source/modules/fetch/Response.cpp
index 50d5c8629a0651016371a11d15f16387116cf707..3fcf587dd6e423c35f1462ea4ca14afde17fe620 100644
--- a/third_party/WebKit/Source/modules/fetch/Response.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Response.cpp
@@ -56,7 +56,7 @@ FetchResponseData* createFetchResponseDataFromWebResponse(
response->headerList()->append(i->key, i->value);
}
- response->replaceBodyStreamBuffer(new BodyStreamBuffer(
+ response->replaceBodyStreamBuffer(BodyStreamBuffer::create(
scriptState, new BlobBytesConsumer(scriptState->getExecutionContext(),
webResponse.blobDataHandle())));
@@ -136,16 +136,16 @@ Response* Response::create(ScriptState* scriptState,
// https://crbug.com/335871.
} else if (V8Blob::hasInstance(body, isolate)) {
Blob* blob = V8Blob::toImpl(body.As<v8::Object>());
- bodyBuffer = new BodyStreamBuffer(
+ bodyBuffer = BodyStreamBuffer::create(
scriptState,
new BlobBytesConsumer(executionContext, blob->blobDataHandle()));
contentType = blob->type();
} else if (body->IsArrayBuffer()) {
- bodyBuffer = new BodyStreamBuffer(
+ bodyBuffer = BodyStreamBuffer::create(
scriptState, new FormDataBytesConsumer(
V8ArrayBuffer::toImpl(body.As<v8::Object>())));
} else if (body->IsArrayBufferView()) {
- bodyBuffer = new BodyStreamBuffer(
+ bodyBuffer = BodyStreamBuffer::create(
scriptState, new FormDataBytesConsumer(
V8ArrayBufferView::toImpl(body.As<v8::Object>())));
} else if (V8FormData::hasInstance(body, isolate)) {
@@ -155,25 +155,25 @@ Response* Response::create(ScriptState* scriptState,
// FormDataEncoder::generateUniqueBoundaryString.
contentType = AtomicString("multipart/form-data; boundary=") +
formData->boundary().data();
- bodyBuffer = new BodyStreamBuffer(
+ bodyBuffer = BodyStreamBuffer::create(
scriptState,
new FormDataBytesConsumer(executionContext, formData.release()));
} else if (V8URLSearchParams::hasInstance(body, isolate)) {
RefPtr<EncodedFormData> formData =
V8URLSearchParams::toImpl(body.As<v8::Object>())->toEncodedFormData();
- bodyBuffer = new BodyStreamBuffer(
+ bodyBuffer = BodyStreamBuffer::create(
scriptState,
new FormDataBytesConsumer(executionContext, formData.release()));
contentType = "application/x-www-form-urlencoded;charset=UTF-8";
} else if (ReadableStreamOperations::isReadableStream(scriptState,
bodyValue)) {
- bodyBuffer = new BodyStreamBuffer(scriptState, bodyValue);
+ bodyBuffer = BodyStreamBuffer::create(scriptState, bodyValue);
} else {
String string = toUSVString(isolate, body, exceptionState);
if (exceptionState.hadException())
return nullptr;
- bodyBuffer =
- new BodyStreamBuffer(scriptState, new FormDataBytesConsumer(string));
+ bodyBuffer = BodyStreamBuffer::create(scriptState,
+ new FormDataBytesConsumer(string));
contentType = "text/plain;charset=UTF-8";
}
Response* response =

Powered by Google App Engine
This is Rietveld 408576698