Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: third_party/WebKit/Source/modules/fetch/Request.cpp

Issue 2526293002: [wrapper-tracing] Untangle non-trivial mixin ctors (Closed)
Patch Set: s/new BodyStreamBuffer/BodyStreamBuffer::create/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Request.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Request.cpp b/third_party/WebKit/Source/modules/fetch/Request.cpp
index 2d1c4749a42597c05b247b6a1d6b107be67ec04a..af760ccd3074e035fc1f95055eb21a4de0317cf9 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Request.cpp
@@ -382,7 +382,7 @@ Request* Request::createRequestWithRequestOrString(
// contains no header named `Content-Type`, append
// `Content-Type`/|Content-Type| to |r|'s Headers object. Rethrow any
// exception."
- temporaryBody = new BodyStreamBuffer(scriptState, std::move(init.body));
+ temporaryBody = BodyStreamBuffer::create(scriptState, std::move(init.body));
if (!init.contentType.isEmpty() &&
!r->getHeaders()->has(HTTPNames::Content_Type, exceptionState)) {
r->getHeaders()->append(HTTPNames::Content_Type, init.contentType,
@@ -407,7 +407,7 @@ Request* Request::createRequestWithRequestOrString(
if (inputRequest && inputRequest->bodyBuffer()) {
// "Let |dummyStream| be an empty ReadableStream object."
auto dummyStream =
- new BodyStreamBuffer(scriptState, BytesConsumer::createClosed());
+ BodyStreamBuffer::create(scriptState, BytesConsumer::createClosed());
// "Set |input|'s request's body to a new body whose stream is
// |dummyStream|."
inputRequest->m_request->setBuffer(dummyStream);
@@ -469,7 +469,8 @@ Request* Request::create(ScriptState* scriptState, FetchRequestData* request) {
Request* Request::create(ScriptState* scriptState,
const WebServiceWorkerRequest& webRequest) {
- return new Request(scriptState, webRequest);
+ FetchRequestData* request = FetchRequestData::create(scriptState, webRequest);
+ return new Request(scriptState, request);
}
Request::Request(ScriptState* scriptState,
@@ -486,10 +487,6 @@ Request::Request(ScriptState* scriptState, FetchRequestData* request)
m_headers->setGuard(Headers::RequestGuard);
}
-Request::Request(ScriptState* scriptState,
- const WebServiceWorkerRequest& request)
- : Request(scriptState, FetchRequestData::create(scriptState, request)) {}
-
String Request::method() const {
// "The method attribute's getter must return request's method."
return m_request->method();

Powered by Google App Engine
This is Rietveld 408576698