Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/domain_reliability/uploader_unittest.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix one unittest Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/uploader_unittest.cc
diff --git a/components/domain_reliability/uploader_unittest.cc b/components/domain_reliability/uploader_unittest.cc
index e9614a47e02da88ff47b66b2893dbf9fbb003598..e7734e04deaeb93e11c2400e1b5c4570a13d5d1e 100644
--- a/components/domain_reliability/uploader_unittest.cc
+++ b/components/domain_reliability/uploader_unittest.cc
@@ -29,13 +29,13 @@ class DomainReliabilityUploaderTest : public testing::Test {
uploader_(DomainReliabilityUploader::Create(
url_request_context_getter_)) {}
- DomainReliabilityUploader::UploadCallback MakeUploadCallback(int index) {
+ DomainReliabilityUploader::UploadCallback MakeUploadCallback(size_t index) {
return base::Bind(&DomainReliabilityUploaderTest::OnUploadComplete,
base::Unretained(this),
index);
}
- void OnUploadComplete(int index, bool success) {
+ void OnUploadComplete(size_t index, bool success) {
EXPECT_FALSE(upload_complete_[index]);
upload_complete_[index] = true;
upload_successful_[index] = success;
@@ -46,8 +46,10 @@ class DomainReliabilityUploaderTest : public testing::Test {
scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
scoped_ptr<DomainReliabilityUploader> uploader_;
- std::map<int, bool> upload_complete_;
- std::map<int, bool> upload_successful_;
+ // Whether the upload callback was called for a particular collector index.
+ std::map<size_t, bool> upload_complete_;
+ // Whether the upload to a particular collector was successful.
+ std::map<size_t, bool> upload_successful_;
};
TEST_F(DomainReliabilityUploaderTest, Create) {

Powered by Google App Engine
This is Rietveld 408576698