Domain Reliability: More security review.

components/domain_reliability/uploader.h

Index: components/domain_reliability/uploader.h
diff --git a/components/domain_reliability/uploader.h b/components/domain_reliability/uploader.h
index ede3d2c5f70961160cfdd31d0b7cce4265cbbf81..a9c5211e83f4f4bd2cabc8fbc6445c7ebba87371 100644
--- a/components/domain_reliability/uploader.h
+++ b/components/domain_reliability/uploader.h
@@ -20,16 +20,23 @@ class URLRequestContextGetter;
 
 namespace domain_reliability {
 
+// Uploads Domain Reliability reports to collectors.
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUploader {
  public:
   typedef base::Callback<void(bool success)> UploadCallback;
 
   DomainReliabilityUploader();
+
   virtual ~DomainReliabilityUploader();
 
-  static scoped_ptr<DomainReliabilityUploader> Create(
-      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+  // Creates an uploader that uses the given |url_request_context_getter| to
+  // get a URLRequestContext to use for uploads. (See test_util.h for a mock
+  // version.)
+  static scoped_ptr<DomainReliabilityUploader> Create(const scoped_refptr<
+      net::URLRequestContextGetter>& url_request_context_getter);

[Ryan Sleevi, 2014/04/30 23:58:11]

git-cl format? This doesn't look like the wrapping it would do?

[Deprecated (see juliatuttle), 2014/05/02 19:23:40]

I seem to remember running it once already, and being surprised at this myself.

I ran it again, and it didn't change it.

 
+  // Uploads |report_json| to |upload_url| and calls |callback| when the upload
+  // has either completed or failed.
   virtual void UploadReport(const std::string& report_json,
                             const GURL& upload_url,
                             const UploadCallback& callback) = 0;