Domain Reliability: More security review.

components/domain_reliability/uploader.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
 
 #include <map>
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "components/domain_reliability/domain_reliability_export.h"
 #include "url/gurl.h"
 
 namespace net {
 class URLFetcher;
 class URLRequest;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace domain_reliability {
 
+// Uploads Domain Reliability reports to collectors.
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUploader {
  public:
   typedef base::Callback<void(bool success)> UploadCallback;
 
   DomainReliabilityUploader();
+
   virtual ~DomainReliabilityUploader();
 
-  static scoped_ptr<DomainReliabilityUploader> Create(
-      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);
+  // Creates an uploader that uses the given |url_request_context_getter| to
+  // get a URLRequestContext to use for uploads. (See test_util.h for a mock
+  // version.)
+  static scoped_ptr<DomainReliabilityUploader> Create(const scoped_refptr<
+      net::URLRequestContextGetter>& url_request_context_getter);

[Ryan Sleevi, 2014/04/30 23:58:11]

git-cl format? This doesn't look like the wrapping it would do?

[Deprecated (see juliatuttle), 2014/05/02 19:23:40]

I seem to remember running it once already, and being surprised at this myself.

I ran it again, and it didn't change it.

 
+  // Uploads |report_json| to |upload_url| and calls |callback| when the upload
+  // has either completed or failed.
   virtual void UploadReport(const std::string& report_json,
                             const GURL& upload_url,
                             const UploadCallback& callback) = 0;
 
   static bool URLRequestIsUpload(const net::URLRequest& request);
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_