Chromium Code Reviews Chromium Code Reviews
Issue 252613002:
Domain Reliability: More security review. (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| Index: components/domain_reliability/domain_reliability_export.h |
| diff --git a/components/domain_reliability/domain_reliability_export.h b/components/domain_reliability/domain_reliability_export.h |
| index d0951cc082ca49aa8a2f67aaaa6e32196a5d544e..3dff7d4eb3a33177a8592bdaa7175db9acfbc3ff 100644 |
| --- a/components/domain_reliability/domain_reliability_export.h |
| +++ b/components/domain_reliability/domain_reliability_export.h |
| @@ -8,22 +8,28 @@ |
| #if defined(COMPONENT_BUILD) |
| #if defined(WIN32) |
| +// Component build on Windows |
|
Ryan Sleevi
2014/04/26 02:37:39
Naturally, you won't want to commit these comments
Deprecated (see juliatuttle)
2014/04/28 22:01:13
Done.
|
| #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION) |
| #define DOMAIN_RELIABILITY_EXPORT __declspec(dllexport) |
| #else |
| #define DOMAIN_RELIABILITY_EXPORT __declspec(dllimport) |
| -#endif // defined(DOMAIN_RELIABILITY_IMPLEMENTATION) |
| +#endif |
| #else // defined(WIN32) |
| + |
| +// Component build on not-Windows |
| #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION) |
| #define DOMAIN_RELIABILITY_EXPORT __attribute__((visibility("default"))) |
| #else |
| #define DOMAIN_RELIABILITY_EXPORT |
| #endif |
| -#endif |
| +#endif // defined(WIN32) |
| #else // defined(COMPONENT_BUILD) |
| + |
| +// Not-component build |
| #define DOMAIN_RELIABILITY_EXPORT |
| + |
| #endif |
| #endif // COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_ |
