components/domain_reliability/domain_reliability_export.h - Issue 252613002: Domain Reliability: More security review.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/domain_reliability/domain_reliability_export.h

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/domain_reliability/dispatcher.h ('K') | « components/domain_reliability/dispatcher_unittest.cc ('k') | components/domain_reliability/monitor.h » ('j') | components/domain_reliability/monitor.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_	5 #ifndef COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_

6 #define COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_	6 #define COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_

7	7

8 #if defined(COMPONENT_BUILD)	8 #if defined(COMPONENT_BUILD)

9 #if defined(WIN32)	9 #if defined(WIN32)

10	10

	11 // Component build on Windows
	Ryan Sleevi 2014/04/26 02:37:39 Naturally, you won't want to commit these comments Naturally, you won't want to commit these comments :) Deprecated (see juliatuttle) 2014/04/28 22:01:13 Done. Show quoted text On 2014/04/26 02:37:39, Ryan Sleevi wrote: > Naturally, you won't want to commit these comments :) Done.
11 #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION)	12 #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION)

12 #define DOMAIN_RELIABILITY_EXPORT __declspec(dllexport)	13 #define DOMAIN_RELIABILITY_EXPORT __declspec(dllexport)

13 #else	14 #else

14 #define DOMAIN_RELIABILITY_EXPORT __declspec(dllimport)	15 #define DOMAIN_RELIABILITY_EXPORT __declspec(dllimport)

15 #endif // defined(DOMAIN_RELIABILITY_IMPLEMENTATION)	16 #endif

16	17

17 #else // defined(WIN32)	18 #else // defined(WIN32)

	19

	20 // Component build on not-Windows

18 #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION)	21 #if defined(DOMAIN_RELIABILITY_IMPLEMENTATION)

19 #define DOMAIN_RELIABILITY_EXPORT __attribute__((visibility("default")))	22 #define DOMAIN_RELIABILITY_EXPORT __attribute__((visibility("default")))

20 #else	23 #else

21 #define DOMAIN_RELIABILITY_EXPORT	24 #define DOMAIN_RELIABILITY_EXPORT

22 #endif	25 #endif

23 #endif

24	26

	27 #endif // defined(WIN32)

25 #else // defined(COMPONENT_BUILD)	28 #else // defined(COMPONENT_BUILD)

	29

	30 // Not-component build

26 #define DOMAIN_RELIABILITY_EXPORT	31 #define DOMAIN_RELIABILITY_EXPORT

	32

27 #endif	33 #endif

28	34

29 #endif // COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_	35 #endif // COMPONENTS_DOMAIN_RELIABILITY_DOMAIN_RELIABILITY_EXPORT_H_

OLD	NEW