Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2370)

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2526073003: Re-add the line break attribute (Closed)
Patch Set: --file=/tmp/m Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/automation/automation_node.js ('k') | ui/accessibility/ax_enums.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/accessibility/blink_ax_tree_source.cc
diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc
index f97a7548cd0737fcbb6b4ea079e5c8393d5ed751..fb20ac4b7ef05e364de7a7cd4ef2d1a60d5bd061 100644
--- a/content/renderer/accessibility/blink_ax_tree_source.cc
+++ b/content/renderer/accessibility/blink_ax_tree_source.cc
@@ -547,6 +547,19 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
if (src.isEditable()) {
dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, src.selectionStart());
dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, src.selectionEnd());
+
+#if defined(OS_CHROMEOS)
+ // This attribute will soon be deprecated; see crbug.com/669134.
+ WebVector<int> src_line_breaks;
+ src.lineBreaks(src_line_breaks);
+ if (src_line_breaks.size()) {
+ std::vector<int32_t> line_breaks;
+ line_breaks.reserve(src_line_breaks.size());
+ for (size_t i = 0; i < src_line_breaks.size(); ++i)
+ line_breaks.push_back(src_line_breaks[i]);
+ dst->AddIntListAttribute(ui::AX_ATTR_LINE_BREAKS, line_breaks);
+ }
+#endif // defined OS_CHROMEOS
}
// ARIA role.
« no previous file with comments | « chrome/renderer/resources/extensions/automation/automation_node.js ('k') | ui/accessibility/ax_enums.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698