Issue 2526073002: Previews should exclude a property if its name is a symbol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2526073002: Previews should exclude a property if its name is a symbol (Closed)

Created:
4 years ago by luoe

Modified:
4 years ago

Reviewers:
kozy

CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Previews should exclude a property if its name is a symbol BUG=chromium:405845

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
M	src/inspector/injected-script-source.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/inspector/runtime/evaluate-with-generate-preview.js	View	1	1 chunk	+12 lines, -8 lines	0 comments	Download
M	test/inspector/runtime/evaluate-with-generate-preview-expected.txt	View	1	3 chunks	+15 lines, -5 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 5 (2 generated)

luoe

Please take a look. This is dependent on another patch set that introduced the test ...

4 years ago (2016-12-05 20:22:39 UTC) #3

kozy

Sometimes I found useful to have symbols in preview. For example I've an object with ...

4 years ago (2016-12-06 02:04:45 UTC) #4

luoe

4 years ago (2016-12-06 21:45:37 UTC) #5

This is a valid point, I will close this issue.  Let's not hide symbols.