Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2554623003: Show functions in object previews (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Show functions in object previews Due to the isOwn check, functions inherited through prototype will not be included in a preview. BUG=chromium:645053 Committed: https://crrev.com/c7c19c86a735f99b5051e11d6b63fe70c31468f7 Cr-Commit-Position: refs/heads/master@{#41566}

Patch Set 1 #

Patch Set 2 : Show functions in previews #

Patch Set 3 : rebase to drop symbool cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -17 lines) Patch
M src/inspector/injected-script-source.js View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M test/inspector/runtime/evaluate-with-generate-preview.js View 1 2 2 chunks +30 lines, -8 lines 0 comments Download
M test/inspector/runtime/evaluate-with-generate-preview-expected.txt View 1 2 3 chunks +50 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
luoe
Please take a look
4 years ago (2016-12-06 01:39:23 UTC) #3
kozy
lgtm
4 years ago (2016-12-06 02:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554623003/40001
4 years ago (2016-12-07 22:32:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 22:34:01 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-07 22:34:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c7c19c86a735f99b5051e11d6b63fe70c31468f7
Cr-Commit-Position: refs/heads/master@{#41566}

Powered by Google App Engine
This is Rietveld 408576698