Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2525913002: [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix AccessorInfo mixup in KeyedStoreGeneric BUG=chromium:668101 Committed: https://crrev.com/2661b3e8a5447773a23a219ba085454c459b654b Cr-Commit-Position: refs/heads/master@{#41223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/code-stub-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/keyed-store-generic.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-668101.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jakob Kummerow
4 years ago (2016-11-23 12:57:56 UTC) #2
Igor Sheludko
lgtm
4 years ago (2016-11-23 12:59:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525913002/1
4 years ago (2016-11-23 12:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 13:27:07 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2661b3e8a5447773a23a219ba085454c459b654b Cr-Commit-Position: refs/heads/master@{#41223}
4 years ago (2016-11-23 13:27:30 UTC) #9
Michael Hablich
4 years ago (2016-11-24 08:40:27 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2525253002/ by hablich@chromium.org.

The reason for reverting is: Needed to revert
2661b3e8a5447773a23a219ba085454c459b654b.

Powered by Google App Engine
This is Rietveld 408576698