src/ic/keyed-store-generic.cc - Issue 2525913002: [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/keyed-store-generic.cc

Issue 2525913002: [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/keyed-store-generic.cc

diff --git a/src/ic/keyed-store-generic.cc b/src/ic/keyed-store-generic.cc

index 43eb4f1c8a9c7a69f22dbea9bd5ebe761ce57964..699cb71ac8f07ee1f87fb803997ef106d03f0cde 100644

--- a/src/ic/keyed-store-generic.cc

+++ b/src/ic/keyed-store-generic.cc

@@ -676,7 +676,7 @@ void KeyedStoreGenericAssembler::EmitGenericPropertyStore(

{

Label not_callable(this);

Node* accessor_pair = var_accessor_pair.value();

- GotoIf(IsAccessorPairMap(LoadMap(accessor_pair)), slow);

+ GotoIf(IsAccessorInfoMap(LoadMap(accessor_pair)), slow);

CSA_ASSERT(this, HasInstanceType(accessor_pair, ACCESSOR_PAIR_TYPE));

Node* setter = LoadObjectField(accessor_pair, AccessorPair::kSetterOffset);

Node* setter_map = LoadMap(setter);

« no previous file with comments | « src/code-stub-assembler.h ('k') | test/mjsunit/regress/regress-crbug-668101.js » ('j') | no next file with comments »