headless/lib/browser/headless_web_contents_impl.h - Issue 2525903003: Add Page.stopLoading to devtools and --timeout switch to headless_shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_web_contents_impl.h

Issue 2525903003: Add Page.stopLoading to devtools and --timeout switch to headless_shell (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_web_contents_impl.h

diff --git a/headless/lib/browser/headless_web_contents_impl.h b/headless/lib/browser/headless_web_contents_impl.h

index d7abd377a72a0a7fab0b4407697c41e370281c88..3f9a6984c7b747f374545fb20f94f7efe7f44bb3 100644

--- a/headless/lib/browser/headless_web_contents_impl.h

+++ b/headless/lib/browser/headless_web_contents_impl.h

@@ -74,6 +74,7 @@ class HeadlessWebContentsImpl : public HeadlessWebContents,

bool OpenURL(const GURL& url);

void Close() override;

+ void Stop() override;

Sami 2016/11/23 18:11:32 We'll need this in devtools too, right? Should we

alex clarke (OOO till 29th) 2016/11/24 12:05:04 Yes we should add this to devtools.

std::string GetDevToolsAgentHostId();