Add Page.stopLoading to devtools and --timeout switch to headless_shell

headless/lib/browser/headless_web_contents_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef HEADLESS_LIB_BROWSER_HEADLESS_WEB_CONTENTS_IMPL_H_
 #define HEADLESS_LIB_BROWSER_HEADLESS_WEB_CONTENTS_IMPL_H_
 
 #include <list>
 #include <memory>
 #include <string>
@@ skipping 56 matching lines @@
                            int exit_code) override;
   void RenderProcessHostDestroyed(content::RenderProcessHost* host) override;
 
   // content::WebContentsObserver implementation:
   void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
 
   content::WebContents* web_contents() const;
   bool OpenURL(const GURL& url);
 
   void Close() override;
+  void Stop() override;

[Sami, 2016/11/23 18:11:32]

We'll need this in devtools too, right? Should we just add it there from the
beginning? (Sorry but this is the question I ask myself for every API we add
here :)

[alex clarke (OOO till 29th), 2016/11/24 12:05:04]

Yes we should add this to devtools.

 
   std::string GetDevToolsAgentHostId();
 
   HeadlessBrowserImpl* browser() const;
   HeadlessBrowserContextImpl* browser_context() const;
 
  private:
   // Takes ownership of |web_contents|.
   HeadlessWebContentsImpl(content::WebContents* web_contents,
                           HeadlessBrowserContextImpl* browser_context);
@@ skipping 16 matching lines @@
       std::unordered_map<HeadlessWebContents::Observer*,
                          std::unique_ptr<WebContentsObserverAdapter>>;
   ObserverMap observer_map_;
 
   DISALLOW_COPY_AND_ASSIGN(HeadlessWebContentsImpl);
 };
 
 }  // namespace headless
 
 #endif  // HEADLESS_LIB_BROWSER_HEADLESS_WEB_CONTENTS_IMPL_H_