Chromium Code Reviews| Index: pylib/gyp/common.py |
| diff --git a/pylib/gyp/common.py b/pylib/gyp/common.py |
| index d7e860184cbdc7fb2af6eab61c25978d60ec7539..d1b178fd914290781cfecbab7c44ca2526f51424 100644 |
| --- a/pylib/gyp/common.py |
| +++ b/pylib/gyp/common.py |
| @@ -496,9 +496,9 @@ class OrderedSet(collections.MutableSet): |
| def discard(self, key): |
| if key in self.map: |
| - key, prev, next = self.map.pop(key) |
| - prev[2] = next |
| - next[1] = prev |
| + key, prev_item, next_item = self.map.pop(key) |
| + prev_item[2] = next_item |
| + next_item[1] = prev_item |
| def __iter__(self): |
| end = self.end |
| @@ -514,6 +514,8 @@ class OrderedSet(collections.MutableSet): |
| yield curr[0] |
| curr = curr[1] |
| + # The second argument is an addition that causes a pylint warning. |
| + # pylint: disable=W0221 |
|
Mark Mentovai
2014/04/28 12:59:16
Should this be on the next line, inline with the “
Daniel Bratell
2014/04/28 14:45:39
I don't know. This was the first pylint control co
|
| def pop(self, last=True): |
| if not self: |
| raise KeyError('set is empty') |