Silence pylint for the imported OrderedSet class.

pylib/gyp/common.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from __future__ import with_statement
 
 import collections
 import errno
 import filecmp
 import os.path
@@ skipping 478 matching lines @@
     return key in self.map
 
   def add(self, key):
     if key not in self.map:
       end = self.end
       curr = end[1]
       curr[2] = end[1] = self.map[key] = [key, curr, end]
 
   def discard(self, key):
     if key in self.map:
-      key, prev, next = self.map.pop(key)
-      prev[2] = next
-      next[1] = prev
+      key, prev_item, next_item = self.map.pop(key)
+      prev_item[2] = next_item
+      next_item[1] = prev_item
 
   def __iter__(self):
     end = self.end
     curr = end[2]
     while curr is not end:
       yield curr[0]
       curr = curr[2]
 
   def __reversed__(self):
     end = self.end
     curr = end[1]
     while curr is not end:
       yield curr[0]
       curr = curr[1]
 
+  # The second argument is an addition that causes a pylint warning.
+  # pylint: disable=W0221

[Mark Mentovai, 2014/04/28 12:59:16]

Should this be on the next line, inline with the “def pop?”

[Daniel Bratell, 2014/04/28 14:45:39]

I don't know. This was the first pylint control comment I've written. Normally I
change the code but since this is a verbatim copy of well-known code I didn't
want to change it so I did what other code seemed to do and it silenced pylint.

   def pop(self, last=True):
     if not self:
       raise KeyError('set is empty')
     key = self.end[1][0] if last else self.end[2][0]
     self.discard(key)
     return key
 
   def __repr__(self):
     if not self:
       return '%s()' % (self.__class__.__name__,)
@@ skipping 51 matching lines @@
       return
     visited.add(node)
     visiting.add(node)
     for neighbor in get_edges(node):
       Visit(neighbor)
     visiting.remove(node)
     ordered_nodes.insert(0, node)
   for node in sorted(graph):
     Visit(node)
   return ordered_nodes