Silence pylint for the imported OrderedSet class.

Silence pylint for the imported OrderedSet class.

Silence two warnings:
OrderedSet.discard: Redefining built-in 'next'
OrderedSet.pop: Arguments number differs from overridden method

Committed r1915

[Daniel Bratell, 2014-04-28 12:20:19]

mark, just a followup to a recent patch. The OrderedSet we imported from the
python recipe was not pylint clean.

No functional changes intended.

[Mark Mentovai, 2014-04-28 12:59:16]

https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py
File pylib/gyp/common.py (right):

https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py#newcode518
pylib/gyp/common.py:518: # pylint: disable=W0221
Should this be on the next line, inline with the “def pop?”

[Daniel Bratell, 2014-04-28 14:45:38]

https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py
File pylib/gyp/common.py (right):

https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py#newcode518
pylib/gyp/common.py:518: # pylint: disable=W0221
On 2014/04/28 12:59:16, Mark Mentovai wrote:
> Should this be on the next line, inline with the “def pop?”

I don't know. This was the first pylint control comment I've written. Normally I
change the code but since this is a verbatim copy of well-known code I didn't
want to change it so I did what other code seemed to do and it silenced pylint.

[Torne, 2014-04-28 14:58:06]

On 2014/04/28 14:45:38, Daniel Bratell wrote:
> https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py
> File pylib/gyp/common.py (right):
> 
>
https://codereview.chromium.org/252583009/diff/1/pylib/gyp/common.py#newcode518
> pylib/gyp/common.py:518: # pylint: disable=W0221
> On 2014/04/28 12:59:16, Mark Mentovai wrote:
> > Should this be on the next line, inline with the “def pop?”
> 
> I don't know. This was the first pylint control comment I've written. Normally
I
> change the code but since this is a verbatim copy of well-known code I didn't
> want to change it so I did what other code seemed to do and it silenced
pylint.

This silences it for the current indentation level from that line onward, I
think; doing it on the end of the "def pop" line will silence it just for that
line, which is probably preferable.

[Shezan Baig (Bloomberg), 2014-05-05 17:00:46]

Daniel, did you get a chance to update this?  I seem to be running into this
exact pylint error when trying to land unrelated gyp changes.  Thanks! :)

[Mark Mentovai, 2014-05-05 17:07:35]

I think that the presubmit check is broken, it should be using the pylintrc file
in GYP, but it’s currently using the one in depot_tools. That gets rid of this
warning in common.py:

W0221:517,2:OrderedSet.pop: Arguments number differs from overridden method

Unfortunately, switching it to use the pylintrc in GYP introduces this one:

R0911:403,0:GetFlavor: Too many return statements (7/6)

[Daniel Bratell, 2014-05-05 18:08:00]

On 2014/05/05 17:00:46, Shezan Baig (Bloomberg) wrote:
> Daniel, did you get a chance to update this?  I seem to be running into this
> exact pylint error when trying to land unrelated gyp changes.  Thanks! :)

I updated the patch last week and then forgot about it. I am currently waiting
for mark to have a look and once he's happy I am going to find someone to land
it for me.

[Mark Mentovai, 2014-05-06 16:36:24]

LGTM

[Mark Mentovai, 2014-05-06 16:40:41]

Committed r1915.

We don’t actually have the “Redefining built-in 'next'” warning when we run
pylint as part of presubmit because that warning (W0622) is suppressed in
PRESUBMIT.py. I’ve committed your patch as-is anyway.