Replace FileUtilProxy with FileProxy in renderer_host/pepper

base/files/file_proxy.h

Index: base/files/file_proxy.h
diff --git a/base/files/file_proxy.h b/base/files/file_proxy.h
index 3c834f673eac90570c6be71095768ca8f90fdebf..b44288f5b504027583fea2c49f09bb7b8c893902 100644
--- a/base/files/file_proxy.h
+++ b/base/files/file_proxy.h
@@ -88,8 +88,13 @@ class BASE_EXPORT FileProxy : public SupportsWeakPtr<FileProxy> {
   // length to simulate a new file), and false otherwise.
   bool created() const { return file_.created(); }
 
+  // This object should not have a valid file_ when this method is called.
+  void SetFile(File file);

[bbudge, 2014/05/14 16:11:58]

It seems logical to put this with the create functions. Just below?
Also, the comment isn't clear about how file_ might be set already. How about
this?

// Sets the file to one that is already open. |file_| should not have been set
by calling CreateOrOpen or CreateTemporary.

[rvargas (doing something else), 2014/05/14 19:47:26]

The only methods in between Create and this one are IsValid(), which is a
concept implicitly needed by this method, and created(), which is only relevant
for Create and not this one. It also sits just by TakeFile() and
GetPlatformFile() which are closely related to SetFile (maybe more than Create)
so it seems better to keep it here.
The problem is that the requirement is not exactly that Create has not been
called, but that IsValid() should return false. Create may fail, or even succeed
as long as TakeFile() or Close() is called after that.

I updated the comments.

+
   File TakeFile();
 
+  PlatformFile GetPlatformFile() const;
+
   // Proxies File::Close. The callback can be null.
   // This returns false if task posting to |task_runner| has failed.
   bool Close(const StatusCallback& callback);
@@ -127,7 +132,6 @@ class BASE_EXPORT FileProxy : public SupportsWeakPtr<FileProxy> {
 
  private:
   friend class FileHelper;
-  void SetFile(File file);
   TaskRunner* task_runner() { return task_runner_.get(); }
 
   scoped_refptr<TaskRunner> task_runner_;