Replace FileUtilProxy with FileProxy in renderer_host/pepper

base/files/file_proxy.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_FILES_FILE_PROXY_H_
 #define BASE_FILES_FILE_PROXY_H_
 
 #include "base/base_export.h"
 #include "base/callback_forward.h"
 #include "base/files/file.h"
@@ skipping 70 matching lines @@
   bool CreateTemporary(uint32 additional_file_flags,
                        const CreateTemporaryCallback& callback);
 
   // Returns true if the underlying |file_| is valid.
   bool IsValid() const;
 
   // Returns true if a new file was created (or an old one truncated to zero
   // length to simulate a new file), and false otherwise.
   bool created() const { return file_.created(); }
 
+  // This object should not have a valid file_ when this method is called.
+  void SetFile(File file);

[bbudge, 2014/05/14 16:11:58]

It seems logical to put this with the create functions. Just below?
Also, the comment isn't clear about how file_ might be set already. How about
this?

// Sets the file to one that is already open. |file_| should not have been set
by calling CreateOrOpen or CreateTemporary.

[rvargas (doing something else), 2014/05/14 19:47:26]

The only methods in between Create and this one are IsValid(), which is a
concept implicitly needed by this method, and created(), which is only relevant
for Create and not this one. It also sits just by TakeFile() and
GetPlatformFile() which are closely related to SetFile (maybe more than Create)
so it seems better to keep it here.
The problem is that the requirement is not exactly that Create has not been
called, but that IsValid() should return false. Create may fail, or even succeed
as long as TakeFile() or Close() is called after that.

I updated the comments.

+
   File TakeFile();
 
+  PlatformFile GetPlatformFile() const;
+
   // Proxies File::Close. The callback can be null.
   // This returns false if task posting to |task_runner| has failed.
   bool Close(const StatusCallback& callback);
 
   // Proxies File::GetInfo. The callback can't be null.
   // This returns false if task posting to |task_runner| has failed.
   bool GetInfo(const GetFileInfoCallback& callback);
 
   // Proxies File::Read. The callback can't be null.
   // This returns false if |bytes_to_read| is less than zero, or
@@ skipping 17 matching lines @@
   // Proxies File::SetLength. The callback can be null.
   // This returns false if task posting to |task_runner| has failed.
   bool SetLength(int64 length, const StatusCallback& callback);
 
   // Proxies File::Flush. The callback can be null.
   // This returns false if task posting to |task_runner| has failed.
   bool Flush(const StatusCallback& callback);
 
  private:
   friend class FileHelper;
-  void SetFile(File file);
   TaskRunner* task_runner() { return task_runner_.get(); }
 
   scoped_refptr<TaskRunner> task_runner_;
   File file_;
   DISALLOW_COPY_AND_ASSIGN(FileProxy);
 };
 
 }  // namespace base
 
 #endif  // BASE_FILES_FILE_PROXY_H_