Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: net/base/sdch_manager.h

Issue 2525743002: Make URLRequestContext a MemoryDumpProvider (Abandoned) (Closed)
Patch Set: self review Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/sdch_manager.h
diff --git a/net/base/sdch_manager.h b/net/base/sdch_manager.h
index dcb47717851b2c825785bf282bd95c370603ac63..91959d495d7a3e01e44dfba0caff1b3510eec99a 100644
--- a/net/base/sdch_manager.h
+++ b/net/base/sdch_manager.h
@@ -32,6 +32,10 @@ class GURL;
namespace base {
class Value;
+
+namespace trace_event {
+class MemoryAllocatorDump;
+}
}
namespace net {
@@ -195,6 +199,11 @@ class NET_EXPORT SdchManager {
void AddObserver(SdchObserver* observer);
void RemoveObserver(SdchObserver* observer);
+ // Called by URLRequestContext to dump memory allocation stats.
+ // |url_request_context_dump| is the associated URLRequestContext memory dump.
eroman 2016/12/01 21:04:37 Would calling this parent_dump (or something like
+ void DumpMemoryStats(
+ base::trace_event::MemoryAllocatorDump* url_request_context_dump) const;
+
// Logs an SDCH failure to UMA and |netlog|.
static void LogSdchProblem(NetLogWithSource netlog, SdchProblemCode problem);

Powered by Google App Engine
This is Rietveld 408576698