Make URLRequestContext a MemoryDumpProvider (Abandoned)

net/base/sdch_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the SdchManager class and the DictionarySet
 // nested class.  The manager is responsible for storing all
 // SdchDictionarys, and provides access to them through DictionarySet
 // objects. A DictionarySet is an object whose lifetime is under the
 // control of the consumer. It is a reference to a set of
 // dictionaries, and guarantees that none of those dictionaries will
@@ skipping 14 matching lines @@
 #include "base/threading/thread_checker.h"
 #include "net/base/net_export.h"
 #include "net/base/sdch_dictionary.h"
 #include "net/base/sdch_problem_codes.h"
 #include "net/log/net_log_with_source.h"
 
 class GURL;
 
 namespace base {
 class Value;
+
+namespace trace_event {
+class MemoryAllocatorDump;
+}
 }
 
 namespace net {
 
 class SdchObserver;
 
 // Provides global database of differential decompression dictionaries for the
 // SDCH filter (processes sdch enconded content).
 //
 // The SdchManager maintains a collection of memory resident dictionaries. It
@@ skipping 143 matching lines @@
                                     const GURL& dictionary_url,
                                     std::string* server_hash_p);
 
   // Remove an SDCH dictionary
   SdchProblemCode RemoveSdchDictionary(const std::string& server_hash);
 
   // Registration for events generated by the SDCH subsystem.
   void AddObserver(SdchObserver* observer);
   void RemoveObserver(SdchObserver* observer);
 
+  // Called by URLRequestContext to dump memory allocation stats.
+  // |url_request_context_dump| is the associated URLRequestContext memory dump.

[eroman, 2016/12/01 21:04:37]

Would calling this parent_dump (or something like that) be reasonable?

The relationship that this is for the URLRequestContext feels like a layering
violation (given that this code is in //net/base, which ideally would not depend
on net/url_request)

+  void DumpMemoryStats(
+      base::trace_event::MemoryAllocatorDump* url_request_context_dump) const;
+
   // Logs an SDCH failure to UMA and |netlog|.
   static void LogSdchProblem(NetLogWithSource netlog, SdchProblemCode problem);
 
   static std::unique_ptr<DictionarySet> CreateEmptyDictionarySetForTesting();
 
  private:
   struct BlacklistInfo {
     BlacklistInfo() : count(0), exponential_count(0), reason(SDCH_OK) {}
 
     int count;               // # of times to refuse SDCH advertisement.
@@ skipping 29 matching lines @@
   base::ObserverList<SdchObserver, true> observers_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_MANAGER_H_