Refactor Reading List Model to use URL as key.

ios/chrome/browser/reading_list/reading_list_store.h

Index: ios/chrome/browser/reading_list/reading_list_store.h
diff --git a/ios/chrome/browser/reading_list/reading_list_store.h b/ios/chrome/browser/reading_list/reading_list_store.h
index 1da170033e35993db42b19aff18ebf1df19c2b1f..d334f0937bec083574cda5956a9e65088e6119f6 100644
--- a/ios/chrome/browser/reading_list/reading_list_store.h
+++ b/ios/chrome/browser/reading_list/reading_list_store.h
@@ -35,8 +35,8 @@ class ReadingListStore : public syncer::ModelTypeSyncBridge,
   void SetReadingListModel(ReadingListModel* model,
                            ReadingListStoreDelegate* delegate) override;
 
-  void SaveEntry(const ReadingListEntry& entry, bool read) override;
-  void RemoveEntry(const ReadingListEntry& entry) override;
+  void SaveEntry(const ReadingListEntry* entry) override;

[jif-google, 2016/11/22 18:21:45]

why a pointer?

[Olivier, 2016/11/28 14:54:15]

done.

+  void RemoveEntry(const ReadingListEntry* entry) override;

[jif-google, 2016/11/22 18:21:45]

same

[Olivier, 2016/11/28 14:54:15]

Done.

 
   // ReadingListModelStorage implementation.
   syncer::ModelTypeSyncBridge* GetModelTypeSyncBridge() override;
@@ -123,8 +123,7 @@ class ReadingListStore : public syncer::ModelTypeSyncBridge,
                          std::unique_ptr<syncer::MetadataBatch> metadata_batch);
 
   void AddEntryToBatch(syncer::MutableDataBatch* batch,
-                       const ReadingListEntry& entry,
-                       bool read);
+                       const ReadingListEntry* entry);

[jif-google, 2016/11/22 18:21:45]

same

[Olivier, 2016/11/28 14:54:15]

Done.

 
   std::unique_ptr<syncer::ModelTypeStore> store_;
   ReadingListModel* model_;