Refactor Reading List Model to use URL as key.

ios/chrome/browser/reading_list/reading_list_store.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_
 #define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_
 
 #include "base/threading/non_thread_safe.h"
 #include "components/sync/model/model_type_store.h"
 #include "components/sync/model/model_type_sync_bridge.h"
@@ skipping 17 matching lines @@
   ReadingListStore(StoreFactoryFunction create_store_callback,
                    const ChangeProcessorFactory& change_processor_factory);
   ~ReadingListStore() override;
 
   std::unique_ptr<ScopedBatchUpdate> EnsureBatchCreated() override;
 
   // ReadingListModelStorage implementation
   void SetReadingListModel(ReadingListModel* model,
                            ReadingListStoreDelegate* delegate) override;
 
-  void SaveEntry(const ReadingListEntry& entry, bool read) override;
-  void RemoveEntry(const ReadingListEntry& entry) override;
+  void SaveEntry(const ReadingListEntry* entry) override;

[jif-google, 2016/11/22 18:21:45]

why a pointer?

[Olivier, 2016/11/28 14:54:15]

done.

+  void RemoveEntry(const ReadingListEntry* entry) override;

[jif-google, 2016/11/22 18:21:45]

same

[Olivier, 2016/11/28 14:54:15]

Done.

 
   // ReadingListModelStorage implementation.
   syncer::ModelTypeSyncBridge* GetModelTypeSyncBridge() override;
 
   // Creates an object used to communicate changes in the sync metadata to the
   // model type store.
   std::unique_ptr<syncer::MetadataChangeList> CreateMetadataChangeList()
       override;
 
   // Perform the initial merge between local and sync data. This should only be
@@ skipping 66 matching lines @@
   void CommitTransaction();
   // Callbacks needed for the database handling.
   void OnDatabaseLoad(
       syncer::ModelTypeStore::Result result,
       std::unique_ptr<syncer::ModelTypeStore::RecordList> entries);
   void OnDatabaseSave(syncer::ModelTypeStore::Result result);
   void OnReadAllMetadata(syncer::SyncError sync_error,
                          std::unique_ptr<syncer::MetadataBatch> metadata_batch);
 
   void AddEntryToBatch(syncer::MutableDataBatch* batch,
-                       const ReadingListEntry& entry,
-                       bool read);
+                       const ReadingListEntry* entry);

[jif-google, 2016/11/22 18:21:45]

same

[Olivier, 2016/11/28 14:54:15]

Done.

 
   std::unique_ptr<syncer::ModelTypeStore> store_;
   ReadingListModel* model_;
   ReadingListStoreDelegate* delegate_;
   StoreFactoryFunction create_store_callback_;
 
   int pending_transaction_count_;
   std::unique_ptr<syncer::ModelTypeStore::WriteBatch> batch_;
 };
 
 #endif  // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_STORE_H_