Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: components/suggestions/proto/suggestions.proto

Issue 2525653002: NewTabPage: Remove impression/click ping plumbing for local NTP (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/proto/suggestions.proto
diff --git a/components/suggestions/proto/suggestions.proto b/components/suggestions/proto/suggestions.proto
index 12621e4b7eb7f6ba883a2421ed29a316395db4e2..27f5d141c33145bbaf1c9e3310555a7a1f97c8c6 100644
--- a/components/suggestions/proto/suggestions.proto
+++ b/components/suggestions/proto/suggestions.proto
@@ -52,10 +52,6 @@ message ChromeSuggestion {
// The timestamp (usec) at which this suggestion ceases to be valid.
optional int64 expiry_ts = 7;
-
- // URL that should be pinged back when the suggestion is shown/clicked.
- optional string impression_url = 13;
- optional string click_url = 14;
mastiz 2016/11/28 13:46:22 Can you please either: a) Mark field tags 13 and 1
Marc Treib 2016/11/28 13:56:47 There already is a comment above ("Next tag: 15")
}
// A list of URLs that should be filtered from the SuggestionsProfile.

Powered by Google App Engine
This is Rietveld 408576698