runtime/bin/loader.cc - Issue 2525623002: VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/loader.cc

Issue 2525623002: VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program) (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/loader.cc

diff --git a/runtime/bin/loader.cc b/runtime/bin/loader.cc

index fdeae6ca63facc14fd62fa2acf221697a7fc62a9..f92eb765e21cbccc5305ee91616b4424cbed45f7 100644

--- a/runtime/bin/loader.cc

+++ b/runtime/bin/loader.cc

@@ -370,8 +370,6 @@ bool Loader::ProcessResultLocked(Loader* loader, Loader::IOResult* result) {

if (payload_type == DartUtils::kSnapshotMagicNumber) {

dart_result = Dart_LoadScriptFromSnapshot(payload, payload_length);

reload_extensions = true;

- } else if (payload_type == DartUtils::kKernelMagicNumber) {

- dart_result = Dart_LoadKernel(payload, payload_length);

} else {

dart_result = Dart_LoadScript(uri, resolved_uri, source, 0, 0);

}

« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | runtime/bin/main.cc » ('j') | no next file with comments »