VM: [Kernel] Split kernel API into 3 steps: ([read binary], parse-binary, bootstrap, load program)

runtime/bin/main.cc

Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index fc9af70c529d42a6888ad15a7cb52c77f00b2731..8accb9221209f85510cbbd0d772bf5dc20849200 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -806,18 +806,19 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
       !run_app_snapshot &&
       TryReadKernel(script_uri, &kernel_file, &kernel_length);
 
+  void* kernel_program = NULL;
+  if (is_kernel) {
+    kernel_program = Dart_ReadKernelBinary(kernel_file, kernel_length);
+    free(const_cast<uint8_t*>(kernel_file));
+  }
+
   IsolateData* isolate_data =
       new IsolateData(script_uri, package_root, packages_config);
   Dart_Isolate isolate =
-      is_kernel ? Dart_CreateIsolateFromKernel(script_uri, main, kernel_file,
-                                               kernel_length, flags,
-                                               isolate_data, error)
+      is_kernel ? Dart_CreateIsolateFromKernel(script_uri, main, kernel_program,
+                                               flags, isolate_data, error)
                 : Dart_CreateIsolate(script_uri, main, isolate_snapshot_buffer,
                                      flags, isolate_data, error);
-  if (is_kernel) {
-    free(const_cast<uint8_t*>(kernel_file));
-  }
-
   if (isolate == NULL) {
     delete isolate_data;
     return NULL;
@@ -830,12 +831,7 @@ static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
   CHECK_RESULT(result);
 
   if (is_kernel) {
-    // TODO(27590): We should not read the kernel file again!
-    if (!TryReadKernel(script_uri, &kernel_file, &kernel_length)) {
-      FATAL("Failed to read kernel second time");
-    }
-    Dart_Handle result = Dart_LoadKernel(kernel_file, kernel_length);
-    free(const_cast<uint8_t*>(kernel_file));
+    Dart_Handle result = Dart_LoadKernel(kernel_program);
     CHECK_RESULT(result);
   }
   if (is_kernel || (isolate_snapshot_buffer != NULL)) {