Revert of Change some source_sets to static_library to shrink binary

Revert of Change some source_sets to static_library to shrink binary (patchset #1 id:1 of https://codereview.chromium.org/2519103003/ )

Reason for revert:
It looks like this fails when rolled into Chromium, with this error:

Undefined symbols for architecture x86_64:
  "_NaClSwitch", referenced from:
      _NaClSyscallSegRegsSaved in nacl_syscall_64.o
     (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
  "_nacl_current_thread_tls_offset", referenced from:
      _NaClSyscallSeg in nacl_syscall_64.o
      _NaClGetTlsFastPath1 in nacl_syscall_64.o
      _NaClGetTlsFastPath1End in nacl_syscall_64.o
ld: symbol(s) not found for architecture x86_64

from:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
https://codereview.chromium.org/2523593005/

with these gn settings:

goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = true
symbol_level = 1
use_goma = true

Original issue's description:
> Change some source_sets to static_library to shrink binary
> 
> The gn generated binaries are bigger than the gyp generated binaries.
> One of the known differences was due to the nacl_global_rng and
> g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
> gyp's. In some cases these global variables can serve as effective
> canaries - removing them can lead to much code going away as well.
> 
> Changing from source_set to static_library means that the linker is not
> required to link in the associated .obj files, which can save time and
> space.
> 
> In this case no code was removed so the space savings was small - just
> the 1.5 KB of space consumed by the globals.
> 
> R=phosek@chromium.org
> BUG=630755
> 
> Committed: https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b011729ee6eaab3384b89a7bfd0ecba73

TBR=phosek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630755
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/e4a9254d3505ec07c15bb40597136e0062bec9dc

[brucedawson, 2016-11-22 19:33:48]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-11-22 19:33:48]

Created Revert of Change some source_sets to static_library to shrink binary

[commit-bot: I haz the power, 2016-11-22 19:33:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 19:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 19:33:57]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-nacl-committers".
Note that this has nothing to do with OWNERS files.

[Mark Seaborn, 2016-11-22 19:35:00]

LGTM

[Mark Seaborn, 2016-11-22 21:32:20]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:32:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479850340205320, "parent_rev":
"508aaa7b011729ee6eaab3384b89a7bfd0ecba73", "commit_rev":
"e4a9254d3505ec07c15bb40597136e0062bec9dc"}

[commit-bot: I haz the power, 2016-11-22 21:32:32]

Description was changed from

==========
Revert of Change some source_sets to static_library to shrink binary (patchset
#1 id:1 of https://codereview.chromium.org/2519103003/ )

Reason for revert:
It looks like this fails when rolled into Chromium, with this error:

Undefined symbols for architecture x86_64:
  "_NaClSwitch", referenced from:
      _NaClSyscallSegRegsSaved in nacl_syscall_64.o
     (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
  "_nacl_current_thread_tls_offset", referenced from:
      _NaClSyscallSeg in nacl_syscall_64.o
      _NaClGetTlsFastPath1 in nacl_syscall_64.o
      _NaClGetTlsFastPath1End in nacl_syscall_64.o
ld: symbol(s) not found for architecture x86_64

from:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
https://codereview.chromium.org/2523593005/

with these gn settings:

goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = true
symbol_level = 1
use_goma = true

Original issue's description:
> Change some source_sets to static_library to shrink binary
> 
> The gn generated binaries are bigger than the gyp generated binaries.
> One of the known differences was due to the nacl_global_rng and
> g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
> gyp's. In some cases these global variables can serve as effective
> canaries - removing them can lead to much code going away as well.
> 
> Changing from source_set to static_library means that the linker is not
> required to link in the associated .obj files, which can save time and
> space.
> 
> In this case no code was removed so the space savings was small - just
> the 1.5 KB of space consumed by the globals.
> 
> R=phosek@chromium.org
> BUG=630755
> 
> Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...

TBR=phosek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630755
==========

to

==========
Revert of Change some source_sets to static_library to shrink binary (patchset
#1 id:1 of https://codereview.chromium.org/2519103003/ )

Reason for revert:
It looks like this fails when rolled into Chromium, with this error:

Undefined symbols for architecture x86_64:
  "_NaClSwitch", referenced from:
      _NaClSyscallSegRegsSaved in nacl_syscall_64.o
     (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
  "_nacl_current_thread_tls_offset", referenced from:
      _NaClSyscallSeg in nacl_syscall_64.o
      _NaClGetTlsFastPath1 in nacl_syscall_64.o
      _NaClGetTlsFastPath1End in nacl_syscall_64.o
ld: symbol(s) not found for architecture x86_64

from:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
https://codereview.chromium.org/2523593005/

with these gn settings:

goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = true
symbol_level = 1
use_goma = true

Original issue's description:
> Change some source_sets to static_library to shrink binary
> 
> The gn generated binaries are bigger than the gyp generated binaries.
> One of the known differences was due to the nacl_global_rng and
> g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
> gyp's. In some cases these global variables can serve as effective
> canaries - removing them can lead to much code going away as well.
> 
> Changing from source_set to static_library means that the linker is not
> required to link in the associated .obj files, which can save time and
> space.
> 
> In this case no code was removed so the space savings was small - just
> the 1.5 KB of space consumed by the globals.
> 
> R=phosek@chromium.org
> BUG=630755
> 
> Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...

TBR=phosek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630755

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/e4a9254d3...
==========

[commit-bot: I haz the power, 2016-11-22 21:32:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/e4a9254d3...