Change some source_sets to static_library to shrink binary

Change some source_sets to static_library to shrink binary

The gn generated binaries are bigger than the gyp generated binaries.
One of the known differences was due to the nacl_global_rng and
g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
gyp's. In some cases these global variables can serve as effective
canaries - removing them can lead to much code going away as well.

Changing from source_set to static_library means that the linker is not
required to link in the associated .obj files, which can save time and
space.

In this case no code was removed so the space savings was small - just
the 1.5 KB of space consumed by the globals.

R=phosek@chromium.org
BUG=630755
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b011729ee6eaab3384b89a7bfd0ecba73

[brucedawson, 2016-11-22 03:11:13]

PTAL

This is ultimately a disappointing change because I was hoping that eliminating
these two global variables would save much more memory. But, might as well avoid
pulling them in given that it is a simple change that ultimately saves a tiny
bit of binary size.

Changing more nacl source_set targets to static_library is possible but does not
further reduce binary size. It might be worth doing because the new
recommendation is to default to static_library, but ignoring them is also
reasonable.

[Petr Hosek, 2016-11-22 10:57:44]

lgtm

[brucedawson, 2016-11-22 18:17:30]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:17:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:47:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479838650635820, "parent_rev":
"0846b7b2d30809fd8b1cc29ff80a769fb741bc59", "commit_rev":
"508aaa7b011729ee6eaab3384b89a7bfd0ecba73"}

[commit-bot: I haz the power, 2016-11-22 18:47:47]

Description was changed from

==========
Change some source_sets to static_library to shrink binary

The gn generated binaries are bigger than the gyp generated binaries.
One of the known differences was due to the nacl_global_rng and
g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
gyp's. In some cases these global variables can serve as effective
canaries - removing them can lead to much code going away as well.

Changing from source_set to static_library means that the linker is not
required to link in the associated .obj files, which can save time and
space.

In this case no code was removed so the space savings was small - just
the 1.5 KB of space consumed by the globals.

R=phosek@chromium.org
BUG=630755
==========

to

==========
Change some source_sets to static_library to shrink binary

The gn generated binaries are bigger than the gyp generated binaries.
One of the known differences was due to the nacl_global_rng and
g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
gyp's. In some cases these global variables can serve as effective
canaries - removing them can lead to much code going away as well.

Changing from source_set to static_library means that the linker is not
required to link in the associated .obj files, which can save time and
space.

In this case no code was removed so the space savings was small - just
the 1.5 KB of space consumed by the globals.

R=phosek@chromium.org
BUG=630755

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...
==========

[commit-bot: I haz the power, 2016-11-22 18:47:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...

[Mark Seaborn, 2016-11-22 19:27:44]

It looks like this fails when rolled into Chromium, with this error:

Undefined symbols for architecture x86_64:
  "_NaClSwitch", referenced from:
      _NaClSyscallSegRegsSaved in nacl_syscall_64.o
     (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
  "_nacl_current_thread_tls_offset", referenced from:
      _NaClSyscallSeg in nacl_syscall_64.o
      _NaClGetTlsFastPath1 in nacl_syscall_64.o
      _NaClGetTlsFastPath1End in nacl_syscall_64.o
ld: symbol(s) not found for architecture x86_64

from:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
https://codereview.chromium.org/2523593005/

Are any corresponding Chromium-side changes required to make this work, or
should this be reverted?

[Mark Seaborn, 2016-11-22 19:27:57]

Description was changed from

==========
Change some source_sets to static_library to shrink binary

The gn generated binaries are bigger than the gyp generated binaries.
One of the known differences was due to the nacl_global_rng and
g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
gyp's. In some cases these global variables can serve as effective
canaries - removing them can lead to much code going away as well.

Changing from source_set to static_library means that the linker is not
required to link in the associated .obj files, which can save time and
space.

In this case no code was removed so the space savings was small - just
the 1.5 KB of space consumed by the globals.

R=phosek@chromium.org
BUG=630755

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...
==========

to

==========
Change some source_sets to static_library to shrink binary

The gn generated binaries are bigger than the gyp generated binaries.
One of the known differences was due to the nacl_global_rng and
g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
gyp's. In some cases these global variables can serve as effective
canaries - removing them can lead to much code going away as well.

Changing from source_set to static_library means that the linker is not
required to link in the associated .obj files, which can save time and
space.

In this case no code was removed so the space savings was small - just
the 1.5 KB of space consumed by the globals.

R=phosek@chromium.org
BUG=630755

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b0...
==========

[brucedawson, 2016-11-22 19:32:59]

> Are any corresponding Chromium-side changes required to make this work, or
> should this be reverted?

I'll revert and then investigate further. Those link errors are unexpected and
were not seen in local testing. The failures were seen in a Mac build with these
settings:

goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = true
symbol_level = 1
use_goma = true

[brucedawson, 2016-11-22 19:33:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2525583003/ by brucedawson@chromium.org.

The reason for reverting is: It looks like this fails when rolled into Chromium,
with this error:

Undefined symbols for architecture x86_64:
  "_NaClSwitch", referenced from:
      _NaClSyscallSegRegsSaved in nacl_syscall_64.o
     (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
  "_nacl_current_thread_tls_offset", referenced from:
      _NaClSyscallSeg in nacl_syscall_64.o
      _NaClGetTlsFastPath1 in nacl_syscall_64.o
      _NaClGetTlsFastPath1End in nacl_syscall_64.o
ld: symbol(s) not found for architecture x86_64

from:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
https://codereview.chromium.org/2523593005/

with these gn settings:

goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = true
symbol_level = 1
use_goma = true.