|
|
DescriptionVEA unittest: add a test case for cache line-alignment
Linux refuses to accept buffers that have sizes ualigned to
CPU cache line, which can be 128 bytes on certain devices.
This test inputs a frame that has unaligned size of U and V
planes to catch such errors.
BUG=664039
TEST=Run VEA unittest on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a
Committed: https://crrev.com/bf4e9d86a27ed1604fbc227209381d529b679fa6
Cr-Original-Commit-Position: refs/heads/master@{#435179}
Cr-Commit-Position: refs/heads/master@{#435566}
Patch Set 1 #Patch Set 2 : VEA unittest: add a test case for cache line-alignment #Patch Set 3 : VEA unittest: add a test case for cache line-alignment #
Total comments: 6
Patch Set 4 : VEA unittest: add a test case for cache line-alignment #
Total comments: 18
Patch Set 5 : VEA unittest: add a test case for cache line-alignment #
Total comments: 10
Patch Set 6 : VEA unittest: add a test case for cache line-alignment #
Total comments: 4
Patch Set 7 : VEA unittest: add a test case for cache line-alignment #Patch Set 8 : VEA unittest: add a test case for cache line-alignment #Patch Set 9 : VEA unittest: add a test case for cache line-alignment #Messages
Total messages: 52 (33 generated)
Description was changed from ========== VEA unittest: add a test case for cache line-alignment This is used to test b/32690953. Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=test on device. ========== to ========== VEA unittest: add a test case for cache line-alignment This is used to test b/32690953. Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=test on device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
hywu@chromium.org changed reviewers: + henryhsu@chromium.org, hywu@chromium.org, posciak@chromium.org, wuchengli@chromium.org
wuchengli@chromium.org changed reviewers: + owenlin@chromium.org
Henry and Owen. Please help review this.
https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1764: class VEANoInputClient : public VideoEncodeAccelerator::Client { There are some boilerplate code in every VEAXxxClient. Extract the common variables of VEAClient, VEANoInputClient, and VEACacheLineUnalignedInputClient to a parent class. For example, next_output_buffer_id_, output_shms_, note_, encoder_, thread_checker_, SetState(), has_encoder(), and NotifyError(). https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1791: // Used to notify another thread about the state. VEAClient does not own this. Please run git cl format to check the style.
https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1765: public: Did you change the code here on purpose? I think the identation is wrong here. There should be just one space before "public:" Please prepare another patch set for review, thanks.
https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1764: class VEANoInputClient : public VideoEncodeAccelerator::Client { On 2016/11/23 14:43:33, wuchengli wrote: > There are some boilerplate code in every VEAXxxClient. Extract the common > variables of VEAClient, VEANoInputClient, and VEACacheLineUnalignedInputClient > to a parent class. For example, next_output_buffer_id_, output_shms_, note_, > encoder_, thread_checker_, SetState(), has_encoder(), and NotifyError(). Done. https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1765: public: On 2016/11/24 03:00:52, Owen Lin wrote: > Did you change the code here on purpose? > > I think the identation is wrong here. > There should be just one space before "public:" > > Please prepare another patch set for review, thanks. Done. https://codereview.chromium.org/2525563005/diff/40001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1791: // Used to notify another thread about the state. VEAClient does not own this. On 2016/11/23 14:43:33, wuchengli wrote: > Please run git cl format to check the style. Done.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment This is used to test b/32690953. Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=test on device. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:895: // Used to notify another thread about the state. VEAClient does not own this. s/VEAClient/VEAClientBase/ https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1795: const int default_height_; s/default_width_/width_/ and s/default_height_/height_/. They are not default and are set from the constructor. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1941: /* This client is only used to test input frame with the size of U and V planes Use // comment style to be consistent with the rest of this file. See https://google.github.io/styleguide/cppguide.html#TODO_Comments https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1990: // It's enough to encode just one frame // It's enough to encode just one frame. If plane size is not aligned, VideoEncodeAccelerator::Encode will fail. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2001: VideoFrame::AllocationSize(PIXEL_FORMAT_I420, input_coded_size)); s/PIXEL_FORMAT_I420/kInputFormat/. Same for line 2006 and 2009. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2004: uint8_t* frame_data_u = The starting address of u and v planes need to be aligned. Allocate three vectors. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2178: ASSERT_EQ(state, note->Wait()); s/ASSERT_EQ/EXPECT_EQ/ so |client| will be always destroyed on the right thread. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2189: TEST(VEACacheLineUnalignedInputTest, CheckOutput) { Combine TEST(VEANoInputTest, CheckOutput) and TEST(VEACacheLineUnalignedInputTest, CheckOutput) because they are the same. Use VideoEncodeAcceleratorTest and INSTANTIATE_TEST_CASE_P. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2208: wait_state = note->Wait(); Use EXPECT_EQ(state, note->Wait());
wuchengli@chromium.org changed reviewers: - henryhsu@chromium.org, posciak@chromium.org
https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:895: // Used to notify another thread about the state. VEAClient does not own this. On 2016/11/28 04:54:42, wuchengli wrote: > s/VEAClient/VEAClientBase/ Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1795: const int default_height_; On 2016/11/28 04:54:42, wuchengli wrote: > s/default_width_/width_/ and s/default_height_/height_/. They are not default > and are set from the constructor. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1941: /* This client is only used to test input frame with the size of U and V planes On 2016/11/28 04:54:42, wuchengli wrote: > Use // comment style to be consistent with the rest of this file. See > https://google.github.io/styleguide/cppguide.html#TODO_Comments Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1990: // It's enough to encode just one frame On 2016/11/28 04:54:42, wuchengli wrote: > // It's enough to encode just one frame. If plane size is not aligned, > VideoEncodeAccelerator::Encode will fail. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2001: VideoFrame::AllocationSize(PIXEL_FORMAT_I420, input_coded_size)); On 2016/11/28 04:54:42, wuchengli wrote: > s/PIXEL_FORMAT_I420/kInputFormat/. Same for line 2006 and 2009. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2004: uint8_t* frame_data_u = On 2016/11/28 04:54:42, wuchengli wrote: > The starting address of u and v planes need to be aligned. Allocate three > vectors. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2178: ASSERT_EQ(state, note->Wait()); On 2016/11/28 04:54:42, wuchengli wrote: > s/ASSERT_EQ/EXPECT_EQ/ so |client| will be always destroyed on the right thread. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2189: TEST(VEACacheLineUnalignedInputTest, CheckOutput) { On 2016/11/28 04:54:42, wuchengli wrote: > Combine TEST(VEANoInputTest, CheckOutput) and > TEST(VEACacheLineUnalignedInputTest, CheckOutput) because they are the same. Use > VideoEncodeAcceleratorTest and INSTANTIATE_TEST_CASE_P. Done. https://codereview.chromium.org/2525563005/diff/60001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2208: wait_state = note->Wait(); On 2016/11/28 04:54:42, wuchengli wrote: > Use EXPECT_EQ(state, note->Wait()); Done.
https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:878: // Base class for VEAClient's s/VEAClient's/all VEA clients in this file/ I feel this is clearer. https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1775: // Base class for simple VEAClient's s/VEAClient's/VEA clients/ https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1910: LOG_ASSERT(!has_encoder()); Can we move this to ~VEAClientBase()? Same for line 1973 and 1202. https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1916: encoder_.reset(); encoder_.reset(); is already done in SimpleVEAClientBase::DestroyEncoder();. Do we need to override this function? https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2147: SimpleTestFunc<VEACacheLineUnalignedInputClient>(); else ASSERT(0) << "Invalid test type=" << test_type;
https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:878: // Base class for VEAClient's On 2016/11/29 07:14:47, wuchengli wrote: > s/VEAClient's/all VEA clients in this file/ > > I feel this is clearer. Done. https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1775: // Base class for simple VEAClient's On 2016/11/29 07:14:47, wuchengli wrote: > s/VEAClient's/VEA clients/ Done. https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1910: LOG_ASSERT(!has_encoder()); On 2016/11/29 07:14:47, wuchengli wrote: > Can we move this to ~VEAClientBase()? Same for line 1973 and 1202. Done. https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1916: encoder_.reset(); On 2016/11/29 07:14:46, wuchengli wrote: > encoder_.reset(); is already done in SimpleVEAClientBase::DestroyEncoder();. Do > we need to override this function? Fixed. It is to free the timer: timer_.reset() https://codereview.chromium.org/2525563005/diff/80001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:2147: SimpleTestFunc<VEACacheLineUnalignedInputClient>(); On 2016/11/29 07:14:46, wuchengli wrote: > else > ASSERT(0) << "Invalid test type=" << test_type; Done.
lgtm https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... media/gpu/video_encode_accelerator_unittest.cc:882: LOG(INFO) << "VEAClientBase destructor"; This log is not very useful. Remove. https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... media/gpu/video_encode_accelerator_unittest.cc:2132: ASSERT_GT(2, test_type) << "Invalid test type=" << test_type; s/ASSERT_GT/ASSERT_GE/
https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... media/gpu/video_encode_accelerator_unittest.cc:882: LOG(INFO) << "VEAClientBase destructor"; On 2016/11/30 04:23:40, wuchengli wrote: > This log is not very useful. Remove. Done. https://codereview.chromium.org/2525563005/diff/100001/media/gpu/video_encode... media/gpu/video_encode_accelerator_unittest.cc:2132: ASSERT_GT(2, test_type) << "Invalid test type=" << test_type; On 2016/11/30 04:23:41, wuchengli wrote: > s/ASSERT_GT/ASSERT_GE/ Changed to ASSERT_LT
The CQ bit was checked by hywu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by hywu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hywu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wuchengli@chromium.org Link to the patchset: https://codereview.chromium.org/2525563005/#ps140001 (title: "VEA unittest: add a test case for cache line-alignment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480495413184720, "parent_rev": "76985e2fe486c1aff7ef8b12ab5882847e8b3f7b", "commit_rev": "fed6e169137f125d111a16023cc8a50d302ecd70"}
Message was sent while issue was closed.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179}
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/2542533003/ by battre@chromium.org. The reason for reverting is: Breaks the compilation on mac..
Message was sent while issue was closed.
FYI: Findit identified this CL at revision 435179 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ==========
The CQ bit was checked by hywu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hywu@chromium.org
The CQ bit was checked by hywu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hywu@chromium.org
The CQ bit was checked by hywu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hywu@chromium.org
The CQ bit was checked by hywu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wuchengli@chromium.org Link to the patchset: https://codereview.chromium.org/2525563005/#ps160001 (title: "VEA unittest: add a test case for cache line-alignment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1480574136764140, "parent_rev": "3f3e42234379382a68c4178f5258f5a040fcbd9d", "commit_rev": "e0214e092c6d542ec041146131c50ad662b2765b"}
Message was sent while issue was closed.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Cr-Commit-Position: refs/heads/master@{#435179} ========== to ========== VEA unittest: add a test case for cache line-alignment Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Committed: https://crrev.com/bf4e9d86a27ed1604fbc227209381d529b679fa6 Cr-Original-Commit-Position: refs/heads/master@{#435179} Cr-Commit-Position: refs/heads/master@{#435566} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/bf4e9d86a27ed1604fbc227209381d529b679fa6 Cr-Commit-Position: refs/heads/master@{#435566} |