Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2525513002: Move logic to turn off caret blinking for LayoutTests to LayoutTheme. (Closed)

Created:
4 years, 1 month ago by wkorman
Modified:
4 years, 1 month ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move logic to turn off caret blinking for LayoutTests to LayoutTheme. LayoutThemeMac extends LayoutTheme directly, whereas other themes such as LayoutTheme{Win,Linux} extend LayoutThemeDefault. The logic to turn off caret blinking in LayoutTests was placed in LayoutThemeDefault::caretBlinkInterval() and so was ineffective on Mac. BUG=667403 Committed: https://crrev.com/0210f10d9f5ac5b1f47f374a31dc8f70f33e5539 Cr-Commit-Position: refs/heads/master@{#433780}

Patch Set 1 #

Patch Set 2 : Remove flaky marker from test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
wkorman
4 years, 1 month ago (2016-11-22 01:28:41 UTC) #3
Xianzhu
LGTM. Please also rebase and update TestExpectations.
4 years, 1 month ago (2016-11-22 01:31:48 UTC) #6
wkorman
On 2016/11/22 01:31:48, Xianzhu wrote: > LGTM. > > Please also rebase and update TestExpectations. ...
4 years, 1 month ago (2016-11-22 01:38:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525513002/20001
4 years, 1 month ago (2016-11-22 01:39:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 03:52:29 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 03:55:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0210f10d9f5ac5b1f47f374a31dc8f70f33e5539
Cr-Commit-Position: refs/heads/master@{#433780}

Powered by Google App Engine
This is Rietveld 408576698