Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 2525513002: Move logic to turn off caret blinking for LayoutTests to LayoutTheme. (Closed)
Patch Set: Remove flaky marker from test. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 29 matching lines...) Expand all
40 #include "core/html/shadow/MediaControlElements.h" 40 #include "core/html/shadow/MediaControlElements.h"
41 #include "core/html/shadow/ShadowElementNames.h" 41 #include "core/html/shadow/ShadowElementNames.h"
42 #include "core/html/shadow/SpinButtonElement.h" 42 #include "core/html/shadow/SpinButtonElement.h"
43 #include "core/html/shadow/TextControlInnerElements.h" 43 #include "core/html/shadow/TextControlInnerElements.h"
44 #include "core/layout/LayoutBox.h" 44 #include "core/layout/LayoutBox.h"
45 #include "core/layout/LayoutThemeMobile.h" 45 #include "core/layout/LayoutThemeMobile.h"
46 #include "core/page/FocusController.h" 46 #include "core/page/FocusController.h"
47 #include "core/page/Page.h" 47 #include "core/page/Page.h"
48 #include "core/style/ComputedStyle.h" 48 #include "core/style/ComputedStyle.h"
49 #include "platform/FileMetadata.h" 49 #include "platform/FileMetadata.h"
50 #include "platform/LayoutTestSupport.h"
50 #include "platform/RuntimeEnabledFeatures.h" 51 #include "platform/RuntimeEnabledFeatures.h"
51 #include "platform/Theme.h" 52 #include "platform/Theme.h"
52 #include "platform/fonts/FontSelector.h" 53 #include "platform/fonts/FontSelector.h"
53 #include "platform/text/PlatformLocale.h" 54 #include "platform/text/PlatformLocale.h"
54 #include "platform/text/StringTruncator.h" 55 #include "platform/text/StringTruncator.h"
55 #include "public/platform/Platform.h" 56 #include "public/platform/Platform.h"
56 #include "public/platform/WebFallbackThemeEngine.h" 57 #include "public/platform/WebFallbackThemeEngine.h"
57 #include "public/platform/WebRect.h" 58 #include "public/platform/WebRect.h"
58 #include "wtf/text/StringBuilder.h" 59 #include "wtf/text/StringBuilder.h"
59 60
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 647
647 void LayoutTheme::platformColorsDidChange() { 648 void LayoutTheme::platformColorsDidChange() {
648 Page::platformColorsChanged(); 649 Page::platformColorsChanged();
649 } 650 }
650 651
651 void LayoutTheme::setCaretBlinkInterval(double interval) { 652 void LayoutTheme::setCaretBlinkInterval(double interval) {
652 m_caretBlinkInterval = interval; 653 m_caretBlinkInterval = interval;
653 } 654 }
654 655
655 double LayoutTheme::caretBlinkInterval() const { 656 double LayoutTheme::caretBlinkInterval() const {
656 return m_caretBlinkInterval; 657 // Disable the blinking caret in layout test mode, as it introduces
658 // a race condition for the pixel tests. http://b/1198440
659 return LayoutTestSupport::isRunningLayoutTest() ? 0 : m_caretBlinkInterval;
657 } 660 }
658 661
659 static FontDescription& getCachedFontDescription(CSSValueID systemFontID) { 662 static FontDescription& getCachedFontDescription(CSSValueID systemFontID) {
660 DEFINE_STATIC_LOCAL(FontDescription, caption, ()); 663 DEFINE_STATIC_LOCAL(FontDescription, caption, ());
661 DEFINE_STATIC_LOCAL(FontDescription, icon, ()); 664 DEFINE_STATIC_LOCAL(FontDescription, icon, ());
662 DEFINE_STATIC_LOCAL(FontDescription, menu, ()); 665 DEFINE_STATIC_LOCAL(FontDescription, menu, ());
663 DEFINE_STATIC_LOCAL(FontDescription, messageBox, ()); 666 DEFINE_STATIC_LOCAL(FontDescription, messageBox, ());
664 DEFINE_STATIC_LOCAL(FontDescription, smallCaption, ()); 667 DEFINE_STATIC_LOCAL(FontDescription, smallCaption, ());
665 DEFINE_STATIC_LOCAL(FontDescription, statusBar, ()); 668 DEFINE_STATIC_LOCAL(FontDescription, statusBar, ());
666 DEFINE_STATIC_LOCAL(FontDescription, webkitMiniControl, ()); 669 DEFINE_STATIC_LOCAL(FontDescription, webkitMiniControl, ());
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 // padding - not honored by WinIE, needs to be removed. 912 // padding - not honored by WinIE, needs to be removed.
910 style.resetPadding(); 913 style.resetPadding();
911 914
912 // border - honored by WinIE, but looks terrible (just paints in the control 915 // border - honored by WinIE, but looks terrible (just paints in the control
913 // box and turns off the Windows XP theme) 916 // box and turns off the Windows XP theme)
914 // for now, we will not honor it. 917 // for now, we will not honor it.
915 style.resetBorder(); 918 style.resetBorder();
916 } 919 }
917 920
918 } // namespace blink 921 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/LayoutThemeDefault.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698