Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2525333002: Repaint SVG subtree on viewport changes (resize) (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Repaint SVG subtree on viewport changes (resize) When the (outermost) <svg> is sized using percentages, and an ancestor changes size, the LayoutSVGRoot will be marked for layout (even though the dimension/initial viewport changes.) Since changed dimensions can imply a new scale factor (for instance from interactions with a viewBox) or previously clipped content being exposed, we need to issue paint invalidations for the entire SVG. BUG=665912 Review-Url: https://codereview.chromium.org/2511353002 Cr-Commit-Position: refs/heads/master@{#433622} (cherry picked from commit 69d94df4b088b45440f335e6be53399b80e7292f) Committed: https://chromium.googlesource.com/chromium/src/+/c349060927de152998f689e80b03d3a8866ab0bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/svg/resize-svg-invalidate-children-2.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/svg/resize-svg-invalidate-children-2-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
4 years ago (2016-11-24 12:43:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c349060927de152998f689e80b03d3a8866ab0bb.

Powered by Google App Engine
This is Rietveld 408576698