Repaint SVG subtree on viewport changes (resize)

Repaint SVG subtree on viewport changes (resize)

When the (outermost) <svg> is sized using percentages, and an ancestor
changes size, the LayoutSVGRoot will be marked for layout (even though
the dimension/initial viewport changes.)
Since changed dimensions can imply a new scale factor (for instance from
interactions with a viewBox) or previously clipped content being
exposed, we need to issue paint invalidations for the entire SVG.

BUG=665912
Committed: https://crrev.com/69d94df4b088b45440f335e6be53399b80e7292f
Cr-Commit-Position: refs/heads/master@{#433622}

[fs, 2016-11-18 09:40:33]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:40:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-11-18 11:29:49]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-11-18 12:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 12:17:27]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2016-11-18 15:14:46]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-11-18 15:14:46]

For testharness tests I don't think you need any expected file at all. Have you
tried without it?

[fs, 2016-11-18 15:18:22]

On 2016/11/18 at 15:14:46, schenney wrote:
> For testharness tests I don't think you need any expected file at all. Have
you tried without it?

This is technically speaking not a testharness test... It just so happens that
text-based-repaint.js uses assert_true and assert_false (see
checkObjectPaintInvalidations.) I guess ...report.js may not strictly be needed
though...

[fs, 2016-11-18 15:23:07]

On 2016/11/18 at 15:18:22, fs wrote:
> On 2016/11/18 at 15:14:46, schenney wrote:
> > For testharness tests I don't think you need any expected file at all. Have
you tried without it?
> 
> ... I guess ...report.js may not strictly be needed though...

Ah, no, I think we need that too.

[Stephen Chennney, 2016-11-18 15:31:36]

On 2016/11/18 15:23:07, fs wrote:
> On 2016/11/18 at 15:18:22, fs wrote:
> > On 2016/11/18 at 15:14:46, schenney wrote:
> > > For testharness tests I don't think you need any expected file at all.
Have
> you tried without it?
> > 
> > ... I guess ...report.js may not strictly be needed though...
> 
> Ah, no, I think we need that too.

Thanks for verifying. I'm not comfortable reviewing this but I'll follow along
as a learning experience.

[pdr., 2016-11-21 18:47:35]

LGTM

[fs, 2016-11-21 18:54:11]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-11-21 18:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 20:14:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479754451352730, "parent_rev":
"a5ee408696746cca3a55d4bb5d1989458c9e9813", "commit_rev":
"967f050b3855c36308cd783e5c4b030378400205"}

[commit-bot: I haz the power, 2016-11-21 20:15:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 20:18:53]

Description was changed from

==========
Repaint SVG subtree on viewport changes (resize)

When the (outermost) <svg> is sized using percentages, and an ancestor
changes size, the LayoutSVGRoot will be marked for layout (even though
the dimension/initial viewport changes.)
Since changed dimensions can imply a new scale factor (for instance from
interactions with a viewBox) or previously clipped content being
exposed, we need to issue paint invalidations for the entire SVG.

BUG=665912
==========

to

==========
Repaint SVG subtree on viewport changes (resize)

When the (outermost) <svg> is sized using percentages, and an ancestor
changes size, the LayoutSVGRoot will be marked for layout (even though
the dimension/initial viewport changes.)
Since changed dimensions can imply a new scale factor (for instance from
interactions with a viewBox) or previously clipped content being
exposed, we need to issue paint invalidations for the entire SVG.

BUG=665912

Committed: https://crrev.com/69d94df4b088b45440f335e6be53399b80e7292f
Cr-Commit-Position: refs/heads/master@{#433622}
==========

[commit-bot: I haz the power, 2016-11-21 20:18:54]

Patchset 1 (id:??) landed as
https://crrev.com/69d94df4b088b45440f335e6be53399b80e7292f
Cr-Commit-Position: refs/heads/master@{#433622}