[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part 1.

[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part 1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135, 679977
Review-Url: https://codereview.chromium.org/2525273002
Cr-Commit-Position: refs/heads/master@{#442837}
Committed: https://chromium.googlesource.com/chromium/src/+/f7bdce1813bc2651979ad6f2bab34be1d44bc098

[yoichio, 2016-11-24 09:30:38]

Description was changed from

==========
break word convert

BUG=
==========

to

==========
break word convert

+editing/selection/4947387.html del > modify_move/move_by_paragraph done
+editing/selection/after-line-wrap.html	del >
modify_move/move-forward-after-line-
break.html done
+editing/selection/click-left-of-rtl-wrapping-text.html	del >
mouse/click-left-of-
rtl-... done

BUG=
==========

[yoichio, 2016-11-24 09:30:48]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 09:31:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 10:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 10:43:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yoichio, 2016-12-02 07:38:53]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 07:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 09:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:28:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2017-01-10 09:22:02]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 09:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-01-10 09:24:08]

The CQ bit was unchecked by yoichio@chromium.org

[yoichio, 2017-01-10 09:24:49]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 09:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:38:54]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-01-11 05:22:29]

Description was changed from

==========
break word convert

+editing/selection/4947387.html del > modify_move/move_by_paragraph done
+editing/selection/after-line-wrap.html	del >
modify_move/move-forward-after-line-
break.html done
+editing/selection/click-left-of-rtl-wrapping-text.html	del >
mouse/click-left-of-
rtl-... done

BUG=
==========

to

==========
[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part
1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135
==========

[yoichio, 2017-01-11 05:22:30]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-01-11 05:59:54]

Could you add http://crbug.com/679977 to "BUG="? It is tracking bug for
converting to use w3c test harness.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html
(right):

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html:15:

Could you have two |test()| rather than adding blank line?
One for backward, and another for forward.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html:24:

nit: no need to have an extra blank line.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html
(right):

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:8:
assert_not_equals(window.eventSender, undefined, 'This test requires
eventSender.');
It seems following pattern is better than this, it doesn't produce failed cases:

if (!window.eventSender) {
  assert_no_reached('This test requires eventSender.');
  return;
}

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:19:
container.style.width = width + 'px';
nit: s/width + 'px'/`${width}px`/

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:22:
container.style.width = (width + 1) + 'px';
s/(width + 1) + 'px'/`${width + 1}px`/

[yosin_UTC9, 2017-01-11 06:01:23]

BTW, Could get rid of "[Editing][CodeHealth]" from summary line?
It seems nobody other than you to use this convention.

[yoichio, 2017-01-11 06:58:27]

Description was changed from

==========
[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part
1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135
==========

to

==========
[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part
1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135,679977
==========

[yoichio, 2017-01-11 07:17:31]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-01-11 07:18:57]

> BTW, Could get rid of "[Editing][CodeHealth]" from summary line?
> It seems nobody other than you to use this convention.

Does this header help you reviewing if you prioritize reviewing queue?

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html
(right):

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html:15:

On 2017/01/11 05:59:54, Yosi_UTC9 wrote:
> Could you have two |test()| rather than adding blank line?
> One for backward, and another for forward.

Done.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-paragraph.html:24:

On 2017/01/11 05:59:54, Yosi_UTC9 wrote:
> nit: no need to have an extra blank line.

Done.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html
(right):

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:8:
assert_not_equals(window.eventSender, undefined, 'This test requires
eventSender.');
On 2017/01/11 05:59:54, Yosi_UTC9 wrote:
> It seems following pattern is better than this, it doesn't produce failed
cases:
> 
> if (!window.eventSender) {
>   assert_no_reached('This test requires eventSender.');
>   return;
> }

Done.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:19:
container.style.width = width + 'px';
On 2017/01/11 05:59:54, Yosi_UTC9 wrote:
> nit: s/width + 'px'/`${width}px`/

Done.

https://codereview.chromium.org/2525273002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html:22:
container.style.width = (width + 1) + 'px';
On 2017/01/11 05:59:54, Yosi_UTC9 wrote:
> s/(width + 1) + 'px'/`${width + 1}px`/

Done.

[commit-bot: I haz the power, 2017-01-11 08:27:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 08:27:16]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-11 08:31:16]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-11 08:31:16]

lgtm

[commit-bot: I haz the power, 2017-01-11 08:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:08:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484123476057150,
"parent_rev": "449c02654738a3b6a380827a2f730492662faa30", "commit_rev":
"f7bdce1813bc2651979ad6f2bab34be1d44bc098"}

[commit-bot: I haz the power, 2017-01-11 10:09:20]

Description was changed from

==========
[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part
1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135,679977
==========

to

==========
[Editing][CodeHealth] Convert editing/selection to utilize w3c test harness part
1.

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135,679977

Review-Url: https://codereview.chromium.org/2525273002
Cr-Commit-Position: refs/heads/master@{#442837}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7bdce1813bc2651979ad6f2bab3...
==========

[commit-bot: I haz the power, 2017-01-11 10:09:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7bdce1813bc2651979ad6f2bab3...