Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: services/ui/surfaces/display_compositor.h

Issue 2525213002: Mus: Avoid deadlock during teardown (Closed)
Patch Set: Address Sadrul's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/gpu/gpu_service_internal.cc ('k') | services/ui/surfaces/display_compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/surfaces/display_compositor.h
diff --git a/services/ui/surfaces/display_compositor.h b/services/ui/surfaces/display_compositor.h
index 5d3c2442ff89bcd23eb7b2145f10ff4cbb2c24d1..d31ccfdfd19aaf5e6655bae09339120a698587c9 100644
--- a/services/ui/surfaces/display_compositor.h
+++ b/services/ui/surfaces/display_compositor.h
@@ -17,6 +17,7 @@
#include "gpu/ipc/common/surface_handle.h"
#include "gpu/ipc/in_process_command_buffer.h"
#include "ipc/ipc_channel_handle.h"
+#include "mojo/public/cpp/bindings/binding.h"
#include "services/ui/surfaces/mus_gpu_memory_buffer_manager.h"
namespace gpu {
@@ -46,6 +47,7 @@ class DisplayCompositor : public cc::SurfaceObserver,
scoped_refptr<gpu::InProcessCommandBuffer::Service> gpu_service,
std::unique_ptr<MusGpuMemoryBufferManager> gpu_memory_buffer_manager,
gpu::ImageFactory* image_factory,
+ cc::mojom::DisplayCompositorRequest request,
cc::mojom::DisplayCompositorClientPtr client);
~DisplayCompositor() override;
@@ -88,11 +90,11 @@ class DisplayCompositor : public cc::SurfaceObserver,
// destroyed in order to ensure that all other objects that depend on it have
// access to a valid pointer for the entirety of their liftimes.
cc::SurfaceManager manager_;
+ scoped_refptr<gpu::InProcessCommandBuffer::Service> gpu_service_;
std::unordered_map<cc::FrameSinkId,
std::unique_ptr<GpuCompositorFrameSink>,
cc::FrameSinkIdHash>
compositor_frame_sinks_;
- scoped_refptr<gpu::InProcessCommandBuffer::Service> gpu_service_;
std::unique_ptr<MusGpuMemoryBufferManager> gpu_memory_buffer_manager_;
gpu::ImageFactory* image_factory_;
cc::mojom::DisplayCompositorClientPtr client_;
@@ -107,6 +109,8 @@ class DisplayCompositor : public cc::SurfaceObserver,
cc::FrameSinkIdHash>
temp_references_;
+ mojo::Binding<cc::mojom::DisplayCompositor> binding_;
+
DISALLOW_COPY_AND_ASSIGN(DisplayCompositor);
};
« no previous file with comments | « services/ui/gpu/gpu_service_internal.cc ('k') | services/ui/surfaces/display_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698