Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Unified Diff: services/ui/gpu/gpu_service_internal.h

Issue 2525213002: Mus: Avoid deadlock during teardown (Closed)
Patch Set: Address Sadrul's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/gpu/gpu_main.cc ('k') | services/ui/gpu/gpu_service_internal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/gpu/gpu_service_internal.h
diff --git a/services/ui/gpu/gpu_service_internal.h b/services/ui/gpu/gpu_service_internal.h
index eded37253d7c9602eeea9acc3cd7556f93788913..cbee07d4914ca036d6bd18409a6dbb4ba8d0466c 100644
--- a/services/ui/gpu/gpu_service_internal.h
+++ b/services/ui/gpu/gpu_service_internal.h
@@ -50,13 +50,17 @@ class GpuServiceInternal : public gpu::GpuChannelManagerDelegate,
void Add(mojom::GpuServiceInternalRequest request);
+ void DestroyDisplayCompositor();
+
private:
friend class GpuMain;
- GpuServiceInternal(const gpu::GPUInfo& gpu_info,
- std::unique_ptr<gpu::GpuWatchdogThread> watchdog,
- gpu::GpuMemoryBufferFactory* memory_buffer_factory,
- scoped_refptr<base::SingleThreadTaskRunner> io_runner);
+ GpuServiceInternal(
+ const gpu::GPUInfo& gpu_info,
+ std::unique_ptr<gpu::GpuWatchdogThread> watchdog,
+ gpu::GpuMemoryBufferFactory* memory_buffer_factory,
+ scoped_refptr<base::SingleThreadTaskRunner> io_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner);
gfx::GpuMemoryBufferHandle CreateGpuMemoryBufferFromeHandle(
gfx::GpuMemoryBufferHandle buffer_handle,
@@ -109,7 +113,10 @@ class GpuServiceInternal : public gpu::GpuChannelManagerDelegate,
cc::mojom::DisplayCompositorRequest request,
cc::mojom::DisplayCompositorClientPtrInfo client_info);
+ void DestroyDisplayCompositorOnCompositorThread();
+
scoped_refptr<base::SingleThreadTaskRunner> io_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> compositor_runner_;
// An event that will be signalled when we shutdown.
base::WaitableEvent shutdown_event_;
@@ -123,7 +130,7 @@ class GpuServiceInternal : public gpu::GpuChannelManagerDelegate,
// Information about the GPU, such as device and vendor ID.
gpu::GPUInfo gpu_info_;
- base::Thread compositor_thread_;
+ std::unique_ptr<ui::DisplayCompositor> display_compositor_;
scoped_refptr<gpu::InProcessCommandBuffer::Service> gpu_command_service_;
std::unique_ptr<gpu::SyncPointManager> owned_sync_point_manager_;
« no previous file with comments | « services/ui/gpu/gpu_main.cc ('k') | services/ui/gpu/gpu_service_internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698