Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 252513004: Reland r265807: "Moves the notification icon out of th..." (Closed)

Created:
6 years, 8 months ago by dewittj
Modified:
6 years, 5 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Reland r265807: "Moves the notification icon out of th..." > Moves the notification icon out of the status area overflow. > > This only happens the first time it is created per data dir, > so that the user can change back their setting if desired. > > This approach uses COM to talk with Windows Explorer to > change the user's notification area preferences. > > R=dimich@chromium.org > BUG=347693 > > Review URL: https://codereview.chromium.org/110693004 > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265807 0039d316-1c4b-4281-b951-d872f2087c98 BUG=347693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266091

Patch Set 1 : Original patch from r265807 #

Patch Set 2 : Disable tray size test on Vista since it won't have any effect on a new icon. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+771 lines, -33 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/status_icons/status_icon.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/status_icons/status_icon.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.h View 5 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_win.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.h View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 3 chunks +11 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/status_icons/status_tray_state_changer_interactive_uitest_win.cc View 1 1 chunk +162 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/status_icons/status_tray_state_changer_win.h View 1 chunk +133 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 1 chunk +235 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.h View 2 chunks +32 lines, -12 lines 1 comment Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 6 chunks +87 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dewittj
PTAL, needed to disable the test that actually measures tray size changes on Vista since ...
6 years, 8 months ago (2014-04-24 20:05:44 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-24 20:42:53 UTC) #2
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 8 months ago (2014-04-24 20:45:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/252513004/20001
6 years, 8 months ago (2014-04-24 21:15:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:46:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 22:46:51 UTC) #6
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 8 months ago (2014-04-24 23:16:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/252513004/20001
6 years, 8 months ago (2014-04-24 23:17:39 UTC) #8
commit-bot: I haz the power
Change committed as 266091
6 years, 8 months ago (2014-04-25 02:35:06 UTC) #9
Nico
6 years, 5 months ago (2014-07-18 16:19:53 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/252513004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/status_icons/status_tray_win.h (right):

https://codereview.chromium.org/252513004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/status_icons/status_tray_win.h:19: class
StatusTrayStateChangerProxy {
Since this class has subclasses and is deleted polymorphically (there's a
scoped_ptr<StatusTrayStateChangerProxy> below but it always points at a
subclass), this class should have a virtual destructor – else the subclass
destructor won't be called and subclass members won't be destructed correctly.

Powered by Google App Engine
This is Rietveld 408576698