Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc

Issue 252513004: Reland r265807: "Moves the notification icon out of th..." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable tray size test on Vista since it won't have any effect on a new icon. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/status_icons/status_tray_win.h" 5 #include "chrome/browser/ui/views/status_icons/status_tray_win.h"
6 6
7 #include <commctrl.h> 7 #include <commctrl.h>
8 8
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "chrome/browser/status_icons/status_icon_menu_model.h" 11 #include "chrome/browser/status_icons/status_icon_menu_model.h"
12 #include "chrome/browser/status_icons/status_icon_observer.h" 12 #include "chrome/browser/status_icons/status_icon_observer.h"
13 #include "chrome/browser/ui/views/status_icons/status_icon_win.h" 13 #include "chrome/browser/ui/views/status_icons/status_icon_win.h"
14 #include "grit/chrome_unscaled_resources.h" 14 #include "grit/chrome_unscaled_resources.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 #include "ui/base/resource/resource_bundle.h" 16 #include "ui/base/resource/resource_bundle.h"
17 #include "ui/gfx/image/image_skia.h" 17 #include "ui/gfx/image/image_skia.h"
18 18
19 class FakeStatusTrayStateChangerProxy : public StatusTrayStateChangerProxy {
20 public:
21 FakeStatusTrayStateChangerProxy()
22 : enqueue_called_(false), icon_id_(0), window_(NULL) {}
23
24 virtual void EnqueueChange(UINT icon_id, HWND window) {
25 enqueue_called_ = true;
26 icon_id_ = icon_id;
27 window_ = window;
28 }
29
30 bool enqueue_called() { return enqueue_called_; }
31 UINT icon_id() { return icon_id_; }
32 HWND window() { return window_; }
33
34 private:
35 bool enqueue_called_;
36 UINT icon_id_;
37 HWND window_;
38
39 DISALLOW_COPY_AND_ASSIGN(FakeStatusTrayStateChangerProxy);
40 };
41
19 class FakeStatusIconObserver : public StatusIconObserver { 42 class FakeStatusIconObserver : public StatusIconObserver {
20 public: 43 public:
21 FakeStatusIconObserver() 44 FakeStatusIconObserver()
22 : balloon_clicked_(false), 45 : balloon_clicked_(false),
23 status_icon_click_count_(0) {} 46 status_icon_click_count_(0) {}
24 virtual void OnStatusIconClicked() { 47 virtual void OnStatusIconClicked() {
25 ++status_icon_click_count_; 48 ++status_icon_click_count_;
26 } 49 }
27 virtual void OnBalloonClicked() { balloon_clicked_ = true; } 50 virtual void OnBalloonClicked() { balloon_clicked_ = true; }
28 bool balloon_clicked() const { return balloon_clicked_; } 51 bool balloon_clicked() const { return balloon_clicked_; }
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 120
98 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon( 121 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon(
99 StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip"))); 122 StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip")));
100 UINT message_id = icon->message_id(); 123 UINT message_id = icon->message_id();
101 UINT icon_id = icon->icon_id(); 124 UINT icon_id = icon->icon_id();
102 125
103 tray.RemoveStatusIcon(icon); 126 tray.RemoveStatusIcon(icon);
104 tray.WndProc(NULL, message_id, icon_id, WM_LBUTTONDOWN); 127 tray.WndProc(NULL, message_id, icon_id, WM_LBUTTONDOWN);
105 } 128 }
106 #endif // !defined(USE_AURA) 129 #endif // !defined(USE_AURA)
130
131 TEST(StatusTrayWinTest, EnsureVisibleTest) {
132 StatusTrayWin tray;
133 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
134 gfx::ImageSkia* image = rb.GetImageSkiaNamed(IDR_STATUS_TRAY_ICON);
135
136 FakeStatusTrayStateChangerProxy* proxy =
137 new FakeStatusTrayStateChangerProxy();
138 tray.SetStatusTrayStateChangerProxyForTest(make_scoped_ptr(proxy));
139
140 StatusIconWin* icon = static_cast<StatusIconWin*>(tray.CreateStatusIcon(
141 StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip")));
142
143 icon->ForceVisible();
144 EXPECT_TRUE(proxy->enqueue_called());
145 EXPECT_EQ(proxy->window(), icon->window());
146 EXPECT_EQ(proxy->icon_id(), icon->icon_id());
147 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698