Remove IFWL_CombobBox::DataProvider

Remove IFWL_CombobBox::DataProvider

The height value returned is always 0. This CL removes the plumbing and uses
the 0 value directly.

R=npm@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/7172b71a005c181e9f103ac0e19f6675bf3bc8e8

[dsinclair, 2016-11-23 15:22:05]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-23 15:22:05]

PTAL.

[npm, 2016-11-23 15:46:02]

lgtm

[Tom Sepez, 2016-11-23 16:45:03]

lgtm

[dsinclair, 2016-11-23 17:23:44]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:23:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:26:40]

Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)

[dsinclair, 2016-11-23 17:52:03]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-23 17:52:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2525003002/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-11-23 17:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:53:21]

Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2961)
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[dsinclair, 2016-11-23 17:55:42]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:55:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:57:00]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_asan_...)

[dsinclair, 2016-11-23 18:04:10]

Description was changed from

==========
Remove IFWL_CombobBox::DataProvider

The height value returned is always 0. This CL removes the plumbing and uses
the 0 value directly.
==========

to

==========
Remove IFWL_CombobBox::DataProvider

The height value returned is always 0. This CL removes the plumbing and uses
the 0 value directly.

R=npm@chromium.org, tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/7172b71a005c181e9f103ac0e19f6675bf3b...
==========

[dsinclair, 2016-11-23 18:04:11]

Committed patchset #3 (id:40001) manually as
7172b71a005c181e9f103ac0e19f6675bf3bc8e8 (presubmit successful).