Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2524883003: ABANDONED CL: Disable flaky SharedBufferDispatcherTest.CreateAndMapBuffer on Android. (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL: See rockot@'s comment for details. ---------------------- Disable flaky SharedBufferDispatcherTest.CreateAndMapBuffer on Android. BUG=667848 TBR=rockot@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Łukasz Anforowicz
rockot@, I am TBR-ing a CL to disable a flaky test on Android.
4 years ago (2016-11-23 19:27:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524883003/1
4 years ago (2016-11-23 19:28:36 UTC) #5
Ken Rockot(use gerrit already)
On 2016/11/23 at 19:27:31, lukasza wrote: > rockot@, I am TBR-ing a CL to disable ...
4 years ago (2016-11-23 19:29:34 UTC) #6
Łukasz Anforowicz
4 years ago (2016-11-23 19:39:48 UTC) #8 
On 2016/11/23 19:29:34, Ken Rockot wrote:
> On 2016/11/23 at 19:27:31, lukasza wrote:
> > rockot@, I am TBR-ing a CL to disable a flaky test on Android.
> 
> Please don't. This test is not flaky on its own, and you aren't solving any
> problems by disabling it. See https://crbug.com/666356 which I'm actively
> investigating.

Ok, thanks for catching this and resolving the bug as a duplicate.

Powered by Google App Engine
This is Rietveld 408576698