Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: mojo/edk/system/shared_buffer_dispatcher_unittest.cc

Issue 2524883003: ABANDONED CL: Disable flaky SharedBufferDispatcherTest.CreateAndMapBuffer on Android. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/shared_buffer_dispatcher_unittest.cc
diff --git a/mojo/edk/system/shared_buffer_dispatcher_unittest.cc b/mojo/edk/system/shared_buffer_dispatcher_unittest.cc
index c95bdc3b7042c17e9a604368d73697909ba7aad4..620ab3325b05b7a4748b9130fba6046138d3e993 100644
--- a/mojo/edk/system/shared_buffer_dispatcher_unittest.cc
+++ b/mojo/edk/system/shared_buffer_dispatcher_unittest.cc
@@ -110,7 +110,13 @@ TEST_F(SharedBufferDispatcherTest, ValidateCreateOptionsInvalid) {
}
}
-TEST_F(SharedBufferDispatcherTest, CreateAndMapBuffer) {
+// https://crbug.com/667848: The test below is flaky on some Android bots.
+#if defined(OS_ANDROID)
+#define MAYBE_CreateAndMapBuffer DISABLED_CreateAndMapBuffer
+#else
+#define MAYBE_CreateAndMapBuffer CreateAndMapBuffer
+#endif
+TEST_F(SharedBufferDispatcherTest, MAYBE_CreateAndMapBuffer) {
scoped_refptr<SharedBufferDispatcher> dispatcher;
EXPECT_EQ(MOJO_RESULT_OK, SharedBufferDispatcher::Create(
SharedBufferDispatcher::kDefaultCreateOptions,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698