components/navigation_interception/intercept_navigation_throttle.cc - Issue 2524763002: make NavigationGesture part of public content API and use it outside content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_throttle.cc

Issue 2524763002: make NavigationGesture part of public content API and use it outside content (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/plugins/flash_download_interception_unittest.cc ('k') | components/navigation_interception/navigation_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_throttle.cc

diff --git a/components/navigation_interception/intercept_navigation_throttle.cc b/components/navigation_interception/intercept_navigation_throttle.cc

index 84292c9f8bb201cb2eb98f1eeb99e05dbe5be8cb..d9d45cd79e6b7133d5f484d51772a8b26779133c 100644

--- a/components/navigation_interception/intercept_navigation_throttle.cc

+++ b/components/navigation_interception/intercept_navigation_throttle.cc

@@ -67,9 +67,9 @@ InterceptNavigationThrottle::CheckIfShouldIgnoreNavigation(bool is_redirect) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

NavigationParams navigation_params(

navigation_handle()->GetURL(), navigation_handle()->GetReferrer(),

- navigation_handle()->HasUserGesture(), navigation_handle()->IsPost(),

- navigation_handle()->GetPageTransition(), is_redirect,

- navigation_handle()->IsExternalProtocol(), true);

+ navigation_handle()->GetNavigationGesture(),

+ navigation_handle()->IsPost(), navigation_handle()->GetPageTransition(),

+ is_redirect, navigation_handle()->IsExternalProtocol(), true);

if (run_callback_synchronously_) {

bool should_ignore_navigation = should_ignore_callback_.Run(