Ensure paint properties are rebuilt on window resizes

Ensure paint properties are rebuilt on window resizes

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9a8e6df44aadd67e582db1200cd25ccd7ecf8d43
Cr-Commit-Position: refs/heads/master@{#434790}

[pdr., 2016-11-23 01:43:39]

Description was changed from

==========
Ensure paint properties are rebuilt on window resizes

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
==========

to

==========
Ensure paint properties are rebuilt on window resizes

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2016-11-23 01:43:50]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[pdr., 2016-11-23 01:43:56]

pdr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 02:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:30:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-11-23 02:54:14]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 02:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 05:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 05:59:00]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-11-24 20:10:36]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 20:10:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 22:31:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 22:31:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-11-27 18:00:04]

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:3565: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
slimmingPaintInvalidationEnabled?

[pdr., 2016-11-28 03:15:05]

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:3565: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
On 2016/11/27 at 18:00:04, Xianzhu wrote:
> slimmingPaintInvalidationEnabled?

I've been using RuntimeEnabledFeatures::slimmingPaintV2Enabled for the paint
property tree invalidation work so far, but that may have been a mistake. Should
it be behind RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled? If so,
which parts should be slimmingPaintInvalidationEnabled vs
slimmingPaintV2Enabled?

[Xianzhu, 2016-11-28 17:56:00]

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:3565: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
On 2016/11/28 03:15:05, pdr. wrote:
> On 2016/11/27 at 18:00:04, Xianzhu wrote:
> > slimmingPaintInvalidationEnabled?
> 
> I've been using RuntimeEnabledFeatures::slimmingPaintV2Enabled for the paint
> property tree invalidation work so far, but that may have been a mistake.
Should
> it be behind RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled? If so,
> which parts should be slimmingPaintInvalidationEnabled vs
> slimmingPaintV2Enabled?

Oh, I didn't notice this before. We should use slimmingPaintInvalidationEnabled
where it's guarding property tree building.

[pdr., 2016-11-28 19:03:16]

On 2016/11/28 at 17:56:00, wangxianzhu wrote:
>
https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/FrameView.cpp:3565: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
> On 2016/11/28 03:15:05, pdr. wrote:
> > On 2016/11/27 at 18:00:04, Xianzhu wrote:
> > > slimmingPaintInvalidationEnabled?
> > 
> > I've been using RuntimeEnabledFeatures::slimmingPaintV2Enabled for the paint
> > property tree invalidation work so far, but that may have been a mistake.
Should
> > it be behind RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled? If
so,
> > which parts should be slimmingPaintInvalidationEnabled vs
> > slimmingPaintV2Enabled?
> 
> Oh, I didn't notice this before. We should use
slimmingPaintInvalidationEnabled where it's guarding property tree building.

Ok, mind if I do this in a big followup?

[Xianzhu, 2016-11-28 19:04:30]

On 2016/11/28 19:03:16, pdr. wrote:
> On 2016/11/28 at 17:56:00, wangxianzhu wrote:
> >
>
https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2524733005/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/frame/FrameView.cpp:3565: if
> (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
> > On 2016/11/28 03:15:05, pdr. wrote:
> > > On 2016/11/27 at 18:00:04, Xianzhu wrote:
> > > > slimmingPaintInvalidationEnabled?
> > > 
> > > I've been using RuntimeEnabledFeatures::slimmingPaintV2Enabled for the
paint
> > > property tree invalidation work so far, but that may have been a mistake.
> Should
> > > it be behind RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled? If
> so,
> > > which parts should be slimmingPaintInvalidationEnabled vs
> > > slimmingPaintV2Enabled?
> > 
> > Oh, I didn't notice this before. We should use
> slimmingPaintInvalidationEnabled where it's guarding property tree building.
> 
> Ok, mind if I do this in a big followup?

LGTM.

[Xianzhu, 2016-11-28 19:04:41]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:05:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 19:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:45:16]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pdr., 2016-11-28 23:07:14]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:08:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:13:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480374434816710,
"parent_rev": "435969030f594247cefe22ab43766dc7bef9374f", "commit_rev":
"a8c0047a8e98edddc7c4cbf8586ad298193fc896"}

[commit-bot: I haz the power, 2016-11-29 00:13:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 00:16:07]

Description was changed from

==========
Ensure paint properties are rebuilt on window resizes

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Ensure paint properties are rebuilt on window resizes

This patch ensures the FrameView paint properties are rebuilt when the window
resizes. This fixes a crash if you resized wikipedia.

BUG=667946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/9a8e6df44aadd67e582db1200cd25ccd7ecf8d43
Cr-Commit-Position: refs/heads/master@{#434790}
==========

[commit-bot: I haz the power, 2016-11-29 00:16:08]

Patchset 2 (id:??) landed as
https://crrev.com/9a8e6df44aadd67e582db1200cd25ccd7ecf8d43
Cr-Commit-Position: refs/heads/master@{#434790}