Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2524733005: Ensure paint properties are rebuilt on window resizes (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 2e8b893a56c61e0cb3f56a55d77d91fe29deac6d..128f3c0ad2aedbef48743d89a4161bf9609c0449 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -651,12 +651,6 @@ void FrameView::setContentsSize(const IntSize& size) {
page->chromeClient().contentsSizeChanged(m_frame.get(), size);
frame().loader().restoreScrollPositionAndViewState();
-
- if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
- // The presence of overflow depends on the contents size. The scroll
- // properties can change depending on whether overflow scrolling occurs.
- setNeedsPaintPropertyUpdate();
- }
}
void FrameView::adjustViewSize() {
@@ -3568,6 +3562,11 @@ void FrameView::frameRectsChanged() {
setLayoutSizeInternal(frameRect().size());
setNeedsUpdateViewportIntersection();
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
Xianzhu 2016/11/27 18:00:04 slimmingPaintInvalidationEnabled?
pdr. 2016/11/28 03:15:05 I've been using RuntimeEnabledFeatures::slimmingPa
Xianzhu 2016/11/28 17:56:00 Oh, I didn't notice this before. We should use sli
+ // The overflow clip property depends on the frame rect.
+ setNeedsPaintPropertyUpdate();
+ }
+
for (const auto& child : m_children)
child->frameRectsChanged();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698