Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2524703002: Introduce Response.redirect attribute and add LayoutTest. (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years ago
Reviewers:
tkent, falken
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce Response.redirected attribute and add LayoutTest. https://codereview.chromium.org/2516353002/ introduces URL list of Response. Response.redirected returns true when the size of the list is larger than 1. BUG=658249 Committed: https://crrev.com/ca86b8af14cf71407b6e7ed342c8dbeb268dd51e Cr-Commit-Position: refs/heads/master@{#437555}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js View 3 chunks +11 lines, -0 lines 2 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/fetch.js View 10 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect.js View 15 chunks +34 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-nocors.js View 5 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-password.js View 4 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/redirected-response.html View 4 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.idl View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 76 (68 generated)
horo
falken@ Could you please review this?
4 years ago (2016-12-09 06:28:47 UTC) #61
falken
lgtm https://codereview.chromium.org/2524703002/diff/230001/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js File third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js (right): https://codereview.chromium.org/2524703002/diff/230001/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js#newcode1 third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:1: var SCOPE = BASE_ORIGIN + In CL description: ...
4 years ago (2016-12-09 06:42:02 UTC) #62
horo
tkent@ Could you please review global-interface-listing-expected.txt files?
4 years ago (2016-12-09 08:19:29 UTC) #65
horo
https://codereview.chromium.org/2524703002/diff/230001/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js File third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js (right): https://codereview.chromium.org/2524703002/diff/230001/third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js#newcode1 third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js:1: var SCOPE = BASE_ORIGIN + On 2016/12/09 06:42:02, falken ...
4 years ago (2016-12-09 08:19:54 UTC) #66
tkent
lgtm
4 years ago (2016-12-09 08:27:07 UTC) #69
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524703002/230001
4 years ago (2016-12-09 14:57:39 UTC) #71
commit-bot: I haz the power
Committed patchset #1 (id:230001)
4 years ago (2016-12-09 16:26:26 UTC) #74
commit-bot: I haz the power
4 years ago (2016-12-09 16:29:12 UTC) #76
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca86b8af14cf71407b6e7ed342c8dbeb268dd51e
Cr-Commit-Position: refs/heads/master@{#437555}

Powered by Google App Engine
This is Rietveld 408576698